Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2624533003: Revert of Remove <title> in writing_layout_tests documentation (Closed)

Created:
3 years, 11 months ago by ktyliu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, sashab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove <title> in writing_layout_tests documentation (patchset #2 id:20001 of https://codereview.chromium.org/2617083002/ ) Reason for revert: pwnall@ pointed out that <title> is used in next_default_test_name() Original issue's description: > Remove <title> in writing_layout_tests documentation as it > doesn't appear in test results (thanks to Alan for pointing it out). > > Instead we should focus on writing good test descriptions. > > BUG= > > Review-Url: https://codereview.chromium.org/2617083002 > Cr-Commit-Position: refs/heads/master@{#441876} > Committed: https://chromium.googlesource.com/chromium/src/+/f0c6c6901e6addca3e3025c07f999333a9c53901 TBR=alancutter@chromium.org,thakis@chromium.org,sashab@chromium.org,pwnall@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2624533003 Cr-Commit-Position: refs/heads/master@{#442446} Committed: https://chromium.googlesource.com/chromium/src/+/e0bb9884e496ed4d099bba03efcd6badcf86e9ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M docs/testing/writing_layout_tests.md View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
ktyliu
Created Revert of Remove <title> in writing_layout_tests documentation
3 years, 11 months ago (2017-01-09 22:01:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624533003/1
3 years, 11 months ago (2017-01-09 22:02:59 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-09 22:03:01 UTC) #5
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-09 23:35:36 UTC) #6
pwnall
lgtm
3 years, 11 months ago (2017-01-09 23:48:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624533003/1
3 years, 11 months ago (2017-01-10 00:02:59 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 01:48:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0bb9884e496ed4d099bba03efcd...

Powered by Google App Engine
This is Rietveld 408576698