Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: docs/testing/writing_layout_tests.md

Issue 2624533003: Revert of Remove <title> in writing_layout_tests documentation (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/testing/writing_layout_tests.md
diff --git a/docs/testing/writing_layout_tests.md b/docs/testing/writing_layout_tests.md
index 13d563b53090a7a511cf39539eab438c33eac2dd..f2767c206dedb34307ae5b5972ed16a7271b5d22 100644
--- a/docs/testing/writing_layout_tests.md
+++ b/docs/testing/writing_layout_tests.md
@@ -338,6 +338,7 @@
```html
<!doctype html>
<meta charset="utf-8">
+<title>JavaScript: the true literal</title>
<link rel="help" href="https://tc39.github.io/ecma262/#sec-boolean-literals">
<meta name="assert" value="The true literal is equal to itself and immutable">
<script src="/resources/testharness.js"></script>
@@ -374,7 +375,9 @@
Some points that are not immediately obvious from the example:
-* The `<meta name="assert">` describes the purpose of the entire file.
+* The `<meta name="assert">` describes the purpose of the entire file, and
+ is not redundant to `<title>`. Don't add a `<meta name="assert">` when the
+ information in the `<title>` is sufficient.
* When calling an `assert_` function that compares two values, the first
argument is the actual value (produced by the functionality being tested), and
the second argument is the expected value (known good, golden). The order
@@ -390,6 +393,9 @@
redundant.
* Do not start test case descriptions with redundant terms like "Testing"
or "Test for".
+ * Test files with a single test case should omit the test case description.
+ The file's `<title>` should be sufficient to describe the scenario being
+ tested.
* Asynchronous tests have a few subtleties.
* The `async_test` wrapper calls its function with a test case argument that
is used to signal when the test case is done, and to connect assertion
@@ -510,6 +516,7 @@
```html
<!doctype html>
<meta charset="utf-8">
+<title>DOM: Event.isTrusted for UI events</title>
<link rel="help" href="https://dom.spec.whatwg.org/#dom-event-istrusted">
<link rel="help" href="https://dom.spec.whatwg.org/#constructing-events">
<meta name="assert"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698