Small cleanups in the Kernel FlowGraphBuilder

Small cleanups in the Kernel FlowGraphBuilder

- The flow graph builder is only used to visit Statements and
  Expressions so it does not need TreeVisitor as a base class.  This
  will make refactoring it easier.

- The TranslationHelper is bound to a Thread so we do not need
  Thread::Current where we have a TranslationHelper.

- BlockExpression does not exist in Kernel any more, so it can be
  removed from the C++ AST implementation.

BUG=
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/a39234eede23e97aba5b15ea3430b30a9a455a18

[Kevin Millikin (Google), 2017-01-10 09:23:16]

kmillikin@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2017-01-10 09:43:43]

LGTM

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:1322: Thread* thread = translation_helper_.thread();
We have a macro for this, a "T.thread()" should be enough. (also below)

[kustermann, 2017-01-10 09:45:15]

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:1322: Thread* thread = translation_helper_.thread();
On 2017/01/10 09:43:43, kustermann wrote:
> We have a macro for this, a "T.thread()" should be enough. (also below)

Sorry "H.thread()" :-/

[Kevin Millikin (Google), 2017-01-10 09:50:00]

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc
File runtime/vm/kernel_to_il.cc (right):

https://codereview.chromium.org/2624513005/diff/1/runtime/vm/kernel_to_il.cc#...
runtime/vm/kernel_to_il.cc:1322: Thread* thread = translation_helper_.thread();
On 2017/01/10 09:45:15, kustermann wrote:
> On 2017/01/10 09:43:43, kustermann wrote:
> > We have a macro for this, a "T.thread()" should be enough. (also below)
> 
> Sorry "H.thread()" :-/

Done.

[Kevin Millikin (Google), 2017-01-10 09:51:03]

Description was changed from

==========
Small cleanups in the Kernel FlowGraphBuilder

- The flow graph builder is only used to visit Statements and
  Expressions so it does not need TreeVisitor as a base class.  This
  will make refactoring it easier.

- The TranslationHelper is bound to a Thread so we do not need
  Thread::Current where we have a TranslationHelper.

- BlockExpression does not exist in Kernel any more, so it can be
  removed from the C++ AST implementation.

BUG=
==========

to

==========
Small cleanups in the Kernel FlowGraphBuilder

- The flow graph builder is only used to visit Statements and
  Expressions so it does not need TreeVisitor as a base class.  This
  will make refactoring it easier.

- The TranslationHelper is bound to a Thread so we do not need
  Thread::Current where we have a TranslationHelper.

- BlockExpression does not exist in Kernel any more, so it can be
  removed from the C++ AST implementation.

BUG=
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a39234eede23e97aba5b15ea3430b30a9a455a18
==========

[Kevin Millikin (Google), 2017-01-10 09:51:04]

Committed patchset #2 (id:20001) manually as
a39234eede23e97aba5b15ea3430b30a9a455a18 (presubmit successful).