Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: runtime/vm/kernel_to_il.cc

Issue 2624513005: Small cleanups in the Kernel FlowGraphBuilder (Closed)
Patch Set: Incorporate review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_to_il.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_to_il.cc
diff --git a/runtime/vm/kernel_to_il.cc b/runtime/vm/kernel_to_il.cc
index bcfe6043e52fdab0518f834ea08dafad24e9ffd2..dae30a4a5ac324e08803d83b84ba10b22d76e41f 100644
--- a/runtime/vm/kernel_to_il.cc
+++ b/runtime/vm/kernel_to_il.cc
@@ -1319,7 +1319,7 @@ Object& ConstantEvaluator::EvaluateExpressionSafe(Expression* expression) {
if (setjmp(*jump.Set()) == 0) {
return EvaluateExpression(expression);
} else {
- Thread* thread = Thread::Current();
+ Thread* thread = H.thread();
Error& error = Error::Handle(Z);
error = thread->sticky_error();
thread->clear_sticky_error();
@@ -1850,10 +1850,8 @@ FlowGraphBuilder::FlowGraphBuilder(
InlineExitCollector* exit_collector,
intptr_t osr_id,
intptr_t first_block_id)
- : zone_(Thread::Current()->zone()),
- translation_helper_(Thread::Current(),
- zone_,
- Thread::Current()->isolate()),
+ : translation_helper_(Thread::Current()),
+ zone_(translation_helper_.zone()),
node_(node),
parsed_function_(parsed_function),
osr_id_(osr_id),
@@ -2192,7 +2190,7 @@ Fragment FlowGraphBuilder::CatchBlockEntry(const Array& handler_types,
CatchBlockEntryInstr* entry = new (Z) CatchBlockEntryInstr(
AllocateBlockId(), CurrentTryIndex(), graph_entry_, handler_types,
handler_index, *CurrentException(), *CurrentStackTrace(),
- /* needs_stacktrace = */ true, Thread::Current()->GetNextDeoptId(),
+ /* needs_stacktrace = */ true, H.thread()->GetNextDeoptId(),
should_restore_closure_context);
graph_entry_->AddCatchEntry(entry);
Fragment instructions(entry);
@@ -2562,11 +2560,9 @@ Fragment FlowGraphBuilder::StoreInstanceFieldGuarded(const dart::Field& field) {
if (FLAG_use_field_guards) {
LocalVariable* store_expression = MakeTemporary();
instructions += LoadLocal(store_expression);
- instructions +=
- GuardFieldClass(field_clone, Thread::Current()->GetNextDeoptId());
+ instructions += GuardFieldClass(field_clone, H.thread()->GetNextDeoptId());
instructions += LoadLocal(store_expression);
- instructions +=
- GuardFieldLength(field_clone, Thread::Current()->GetNextDeoptId());
+ instructions += GuardFieldLength(field_clone, H.thread()->GetNextDeoptId());
}
instructions += StoreInstanceField(field_clone);
return instructions;
@@ -4911,13 +4907,6 @@ void FlowGraphBuilder::VisitRethrow(Rethrow* node) {
}
-void FlowGraphBuilder::VisitBlockExpression(BlockExpression* node) {
- Fragment instructions = TranslateStatement(node->body());
- instructions += TranslateExpression(node->value());
- fragment_ = instructions;
-}
-
-
Fragment FlowGraphBuilder::TranslateArguments(Arguments* node,
Array* argument_names) {
Fragment instructions;
« no previous file with comments | « runtime/vm/kernel_to_il.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698