Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: runtime/vm/kernel_binary.cc

Issue 2624513005: Small cleanups in the Kernel FlowGraphBuilder (Closed)
Patch Set: Incorporate review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/kernel.cc ('k') | runtime/vm/kernel_reader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 #if !defined(DART_PRECOMPILED_RUNTIME) 4 #if !defined(DART_PRECOMPILED_RUNTIME)
5 5
6 #include <map> 6 #include <map>
7 #include <vector> 7 #include <vector>
8 8
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 kSymbolLiteral = 44, 87 kSymbolLiteral = 44,
88 kTypeLiteral = 45, 88 kTypeLiteral = 45,
89 kThisExpression = 46, 89 kThisExpression = 46,
90 kRethrow = 47, 90 kRethrow = 47,
91 kThrow = 48, 91 kThrow = 48,
92 kListLiteral = 49, 92 kListLiteral = 49,
93 kMapLiteral = 50, 93 kMapLiteral = 50,
94 kAwaitExpression = 51, 94 kAwaitExpression = 51,
95 kFunctionExpression = 52, 95 kFunctionExpression = 52,
96 kLet = 53, 96 kLet = 53,
97 kBlockExpression = 54,
98 97
99 kPositiveIntLiteral = 55, 98 kPositiveIntLiteral = 55,
100 kNegativeIntLiteral = 56, 99 kNegativeIntLiteral = 56,
101 kBigIntLiteral = 57, 100 kBigIntLiteral = 57,
102 kConstListLiteral = 58, 101 kConstListLiteral = 58,
103 kConstMapLiteral = 59, 102 kConstMapLiteral = 59,
104 103
105 kInvalidStatement = 60, 104 kInvalidStatement = 60,
106 kExpressionStatement = 61, 105 kExpressionStatement = 61,
107 kBlock = 62, 106 kBlock = 62,
(...skipping 1309 matching lines...) Expand 10 before | Expand all | Expand 10 after
1417 case kMapLiteral: 1416 case kMapLiteral:
1418 return MapLiteral::ReadFrom(reader, false); 1417 return MapLiteral::ReadFrom(reader, false);
1419 case kConstMapLiteral: 1418 case kConstMapLiteral:
1420 return MapLiteral::ReadFrom(reader, true); 1419 return MapLiteral::ReadFrom(reader, true);
1421 case kAwaitExpression: 1420 case kAwaitExpression:
1422 return AwaitExpression::ReadFrom(reader); 1421 return AwaitExpression::ReadFrom(reader);
1423 case kFunctionExpression: 1422 case kFunctionExpression:
1424 return FunctionExpression::ReadFrom(reader); 1423 return FunctionExpression::ReadFrom(reader);
1425 case kLet: 1424 case kLet:
1426 return Let::ReadFrom(reader); 1425 return Let::ReadFrom(reader);
1427 case kBlockExpression:
1428 return BlockExpression::ReadFrom(reader);
1429 case kBigIntLiteral: 1426 case kBigIntLiteral:
1430 return BigintLiteral::ReadFrom(reader); 1427 return BigintLiteral::ReadFrom(reader);
1431 case kStringLiteral: 1428 case kStringLiteral:
1432 return StringLiteral::ReadFrom(reader); 1429 return StringLiteral::ReadFrom(reader);
1433 case kSpecialIntLiteral: 1430 case kSpecialIntLiteral:
1434 return IntLiteral::ReadFrom(reader, payload); 1431 return IntLiteral::ReadFrom(reader, payload);
1435 case kNegativeIntLiteral: 1432 case kNegativeIntLiteral:
1436 return IntLiteral::ReadFrom(reader, true); 1433 return IntLiteral::ReadFrom(reader, true);
1437 case kPositiveIntLiteral: 1434 case kPositiveIntLiteral:
1438 return IntLiteral::ReadFrom(reader, false); 1435 return IntLiteral::ReadFrom(reader, false);
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
2123 2120
2124 void Let::WriteTo(Writer* writer) { 2121 void Let::WriteTo(Writer* writer) {
2125 TRACE_WRITE_OFFSET(); 2122 TRACE_WRITE_OFFSET();
2126 VariableScope<WriterHelper> vars(writer->helper()); 2123 VariableScope<WriterHelper> vars(writer->helper());
2127 writer->WriteTag(kLet); 2124 writer->WriteTag(kLet);
2128 variable_->WriteToImpl(writer); 2125 variable_->WriteToImpl(writer);
2129 body_->WriteTo(writer); 2126 body_->WriteTo(writer);
2130 } 2127 }
2131 2128
2132 2129
2133 BlockExpression* BlockExpression::ReadFrom(Reader* reader) {
2134 TRACE_READ_OFFSET();
2135 BlockExpression* be = new BlockExpression();
2136 be->body_ = Block::ReadFromImpl(reader);
2137 be->value_ = Expression::ReadFrom(reader);
2138 return be;
2139 }
2140
2141
2142 void BlockExpression::WriteTo(Writer* writer) {
2143 TRACE_WRITE_OFFSET();
2144 writer->WriteTag(kBlockExpression);
2145 body_->WriteToImpl(writer);
2146 value_->WriteTo(writer);
2147 }
2148
2149
2150 Statement* Statement::ReadFrom(Reader* reader) { 2130 Statement* Statement::ReadFrom(Reader* reader) {
2151 TRACE_READ_OFFSET(); 2131 TRACE_READ_OFFSET();
2152 Tag tag = reader->ReadTag(); 2132 Tag tag = reader->ReadTag();
2153 switch (tag) { 2133 switch (tag) {
2154 case kInvalidStatement: 2134 case kInvalidStatement:
2155 return InvalidStatement::ReadFrom(reader); 2135 return InvalidStatement::ReadFrom(reader);
2156 case kExpressionStatement: 2136 case kExpressionStatement:
2157 return ExpressionStatement::ReadFrom(reader); 2137 return ExpressionStatement::ReadFrom(reader);
2158 case kBlock: 2138 case kBlock:
2159 return Block::ReadFromImpl(reader); 2139 return Block::ReadFromImpl(reader);
(...skipping 774 matching lines...) Expand 10 before | Expand all | Expand 10 after
2934 void WritePrecompiledKernel(ByteWriter* byte_writer, kernel::Program* program) { 2914 void WritePrecompiledKernel(ByteWriter* byte_writer, kernel::Program* program) {
2935 ASSERT(byte_writer != NULL); 2915 ASSERT(byte_writer != NULL);
2936 2916
2937 kernel::Writer writer(byte_writer); 2917 kernel::Writer writer(byte_writer);
2938 program->WriteTo(&writer); 2918 program->WriteTo(&writer);
2939 } 2919 }
2940 2920
2941 2921
2942 } // namespace dart 2922 } // namespace dart
2943 #endif // !defined(DART_PRECOMPILED_RUNTIME) 2923 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « runtime/vm/kernel.cc ('k') | runtime/vm/kernel_reader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698