Add web_dev_style presubmit to ensure <if>/<include> live in comments

Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624503002
Cr-Commit-Position: refs/heads/master@{#443069}
Committed: https://chromium.googlesource.com/chromium/src/+/1d4982588b9a0dc7a6685e850235dbe394eb7731

[Dan Beam, 2017-01-10 01:06:41]

Description was changed from

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

R=dpapad@chromium.org
BUG=678778
==========

to

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

R=dpapad@chromium.org
BUG=678778
==========

[Dan Beam, 2017-01-10 01:06:41]

dbeam@chromium.org changed reviewers:
+ dschuyler@chromium.org
- dpapad@chromium.org

[Dan Beam, 2017-01-10 01:06:50]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:07:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 03:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:10:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Dan Beam, 2017-01-10 04:35:25]

dbeam@chromium.org changed reviewers:
+ tsergeant@chromium.org
- dschuyler@chromium.org

[Dan Beam, 2017-01-10 04:35:33]

Description was changed from

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

R=dpapad@chromium.org
BUG=678778
==========

to

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
==========

[Dan Beam, 2017-01-10 04:36:43]

Description was changed from

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
==========

to

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-10 04:37:01]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-01-10 04:56:57]

as per our IM convo:

a) this check should be in the JS checker
b) checkers should be running on file extensions sanely

current examples of insanity: running the {HTML,CSS}Checkers on .js files

I'll fix the insanity first and then add my new test.

[Dan Beam, 2017-01-11 07:56:56]

On 2017/01/10 04:56:57, Dan Beam wrote:
> as per our IM convo:
> 
> a) this check should be in the JS checker

moved the check to the JSChecker

> b) checkers should be running on file extensions sanely
> 
> current examples of insanity: running the {HTML,CSS}Checkers on .js files
> 
> I'll fix the insanity first and then add my new test.

fixed some weirdness here: https://codereview.chromium.org/2624873003/

[Dan Beam, 2017-01-11 07:57:01]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:57:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 09:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 09:01:12]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tsergeant, 2017-01-11 21:23:51]

lgtm

[Dan Beam, 2017-01-11 21:57:50]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-01-11 21:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2624503002/#ps80001
(title: "'<iframe'")

[commit-bot: I haz the power, 2017-01-11 21:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 00:12:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484171870256950,
"parent_rev": "292538aef0204fdc23f0816a9df911b198b6a8e0", "commit_rev":
"1d4982588b9a0dc7a6685e850235dbe394eb7731"}

[commit-bot: I haz the power, 2017-01-12 00:12:38]

Description was changed from

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add web_dev_style presubmit to ensure <if>/<include> live in comments

Before:

<include src="...">
<if expr="chromeos">
    chromeOsOnlyCode();
</if>

After:

// <includes src="...">
// <if expr="chromeos">
    chromeOsOnlyCode();
// </if>

This is to unblock running clang-format on JavaScript and allow other
tools to run on more expected input inside of .js files (i.e. closure
compiler).

BUG=678778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624503002
Cr-Commit-Position: refs/heads/master@{#443069}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d4982588b9a0dc7a6685e850235...
==========

[commit-bot: I haz the power, 2017-01-12 00:12:39]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1d4982588b9a0dc7a6685e850235...