Add web_dev_style presubmit to ensure <if>/<include> live in comments

chrome/browser/web_dev_style/js_checker_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import js_checker
 from os import path as os_path
 import re
 from sys import path as sys_path
 import test_util
 import unittest
 
 _HERE = os_path.dirname(os_path.abspath(__file__))
 sys_path.append(os_path.join(_HERE, '..', '..', '..', 'build'))
 
 import find_depot_tools  # pylint: disable=W0611
 from testing_support.super_mox import SuperMoxTestBase
 
 
 class JsCheckerTest(SuperMoxTestBase):
   def setUp(self):
     SuperMoxTestBase.setUp(self)
 
     input_api = self.mox.CreateMockAnything()
     input_api.re = re
     output_api = self.mox.CreateMockAnything()
     self.checker = js_checker.JSChecker(input_api, output_api)
 
+  def ShouldFailCommentCheck(self, line):
+    """Checks that uncommented '<if>' and '<include>' are a style error."""
+    error = self.checker.CommentIfAndIncludeCheck(1, line)
+    self.assertNotEqual('', error, 'Should be flagged as style error: ' + line)
+    highlight = test_util.GetHighlight(line, error).strip()
+    self.assertTrue(highlight.startswith(('<if', '<include')))
+
+  def ShouldPassCommentCheck(self, line):
+    """Checks that commented '<if>' and '<include>' are allowed."""
+    self.assertEqual('', self.checker.CommentIfAndIncludeCheck(1, line),
+        'Should not be flagged as style error: ' + line)
+
+  def testCommentFails(self):
+    lines = [
+        '<include src="blah.js">',
+        # Currently, only "// " is accepted (not just "//" or "//\s+") as Python
+        # can't do variable-length lookbehind.
+        '//<include src="blah.js">',
+        '//  <include src="blah.js">',
+        '             <include src="blee.js">',
+        '  <if expr="chromeos">',
+        '<if expr="lang == \'de\'">',
+        '//<if expr="bitness == 64">',
+    ]
+    for line in lines:
+      self.ShouldFailCommentCheck(line)
+
+  def testCommentPasses(self):
+    lines = [
+        '// <include src="assert.js">',
+        '             // <include src="util.js"/>',
+        '// <if expr="chromeos">',
+        '           // <if expr="not chromeos">',
+        "   '<iframe src=blah.html>';",
+    ]
+    for line in lines:
+      self.ShouldPassCommentCheck(line)
+
   def ShouldFailConstCheck(self, line):
     """Checks that the 'const' checker flags |line| as a style error."""
     error = self.checker.ConstCheck(1, line)
     self.assertNotEqual('', error,
         'Should be flagged as style error: ' + line)
     self.assertEqual(test_util.GetHighlight(line, error), 'const')
 
   def ShouldPassConstCheck(self, line):
     """Checks that the 'const' checker doesn't flag |line| as a style error."""
     self.assertEqual('', self.checker.ConstCheck(1, line),
@@ skipping 313 matching lines @@
         " var SCARE_SMALL_CHILDREN = [",         # TODO(dbeam): add @const in
                                                  # front of all these vars like
         "/** @const */ CONST_VAR = 1;",          # this line has (<--).
     ]
     for line in lines:
       self.ShouldPassVarNameCheck(line)
 
 
 if __name__ == '__main__':
   unittest.main()