Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2624133007: Revert of Implement color management for ImageData (patchset #11 id:440001 of https://codereview.ch… (Closed)

Created:
3 years, 11 months ago by zakerinasab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kenjibaheux+watch_chromium.org, tzik, dshwang, eae+blinkwatch, rwlbuis, jsbell+serviceworker_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews, falken+watch_chromium.org, blink-reviews-w3ctests_chromium.org, sof, nhiroki, michaeln, shimazu+serviceworker_chromium.org, ajuma+watch-canvas_chromium.org, tfarina, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement color management for ImageData (patchset #11 id:440001 of https://codereview.chromium.org/2555213002/ ) Reason for revert: This caused Windows test failures on the perf waterfall. See http://crbug.com/680776 Original issue's description: > Implement color management for ImageData > > Implement color management for ImageData as described in this proposal: > github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md > > Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qu73qpdGunE > > BUG=670712 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2555213002 > Cr-Commit-Position: refs/heads/master@{#442973} > Committed: https://chromium.googlesource.com/chromium/src/+/7fb9535883e50ab0d7262ea8a0e8470934e57a9c TBR=jochen@chromium.org,junov@chromium.org,zakerinasab@google.com,zakerinasab@chromium.org BUG=670712 Review-Url: https://codereview.chromium.org/2624133007 Cr-Commit-Position: refs/heads/master@{#443697} Committed: https://chromium.googlesource.com/chromium/src/+/8e66be9f9eab598fe3509d2d2b07f91fea303bac

Patch Set 1 #

Patch Set 2 : Double check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -986 lines) Patch
D third_party/WebKit/LayoutTests/fast/canvas/canvas-Float32ImageData-constructor.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-Float32ImageData-workers.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageData-constructor-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageData-workers-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/canvas-Float32ImageData.js View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/canvas-Float32ImageData-workers.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 4 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.h View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.idl View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 3 chunks +6 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 4 chunks +88 lines, -239 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.idl View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624133007/20001
3 years, 11 months ago (2017-01-13 15:44:46 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-13 15:44:48 UTC) #6
sullivan
lgtm
3 years, 11 months ago (2017-01-13 15:49:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624133007/20001
3 years, 11 months ago (2017-01-13 15:52:27 UTC) #10
Justin Novosad
On 2017/01/13 15:52:27, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-13 16:07:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/370701)
3 years, 11 months ago (2017-01-13 17:09:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624133007/20001
3 years, 11 months ago (2017-01-13 18:49:41 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 22:22:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e66be9f9eab598fe3509d2d2b07...

Powered by Google App Engine
This is Rietveld 408576698