Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2624073002: Gtk3: Fix crash when using Gtk3.20 (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix crash when using Gtk3.20 The gtk3 port of chrome would segfault under the following circumstances: * The version of Gtk is at least 3.20 * Using a non-component build * Using the bundled harfbuzz library This CL adds the same hack used in libgtk2ui to force harfbuzz symbol loading. BUG=462689 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2624073002 Cr-Commit-Position: refs/heads/master@{#443018} Committed: https://chromium.googlesource.com/chromium/src/+/3208d21882b32d287953195f5f062ef251f869ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/libgtkui/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom (Use chromium acct)
3 years, 11 months ago (2017-01-11 02:36:04 UTC) #5
Elliot Glaysher
lgtm
3 years, 11 months ago (2017-01-11 18:09:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624073002/20001
3 years, 11 months ago (2017-01-11 18:37:46 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:27:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3208d21882b32d287953195f5f06...

Powered by Google App Engine
This is Rietveld 408576698