Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/ui/libgtkui/BUILD.gn

Issue 2624073002: Gtk3: Fix crash when using Gtk3.20 (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtkui/BUILD.gn
diff --git a/chrome/browser/ui/libgtkui/BUILD.gn b/chrome/browser/ui/libgtkui/BUILD.gn
index 837861558c49e8f0e93aca2ea5d6114413375824..b7418020e3a9be0985eed4db4da18d424875566b 100644
--- a/chrome/browser/ui/libgtkui/BUILD.gn
+++ b/chrome/browser/ui/libgtkui/BUILD.gn
@@ -126,6 +126,8 @@ group("libgtkui") {
}
}
+# TODO(thomasanderson): libgtk2ui and libgtk3ui share much of the same code.
+# Extract the common code into a template.
component("libgtk2ui") {
sources = common_sources + [
"native_theme_gtk2.cc",
@@ -160,6 +162,13 @@ component("libgtk3ui") {
configs += common_configs
defines = [ "LIBGTKUI_IMPLEMENTATION" ]
+ # GTK3 pulls pangoft2 as dependency, and pangoft2 depends on harfbuzz.
+ # To avoid missing indirectly referenced harfbuzz symbols from pango,
+ # some hack is required when bundled harfbuzz is used and component build is
+ # disabled.
+ # See crbug.com/462689 for details.
+ all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
+
deps = common_deps + [
"//build/config/linux/gtk3",
"//build/config/linux/gtk3:gtkprint3",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698