Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3279)

Unified Diff: chrome/test/data/webui/settings/people_page_change_picture_test.js

Issue 2623993002: MD Settings People: Fix ChromeOS Change Picture arrow keys (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 366-settings-fix-chang… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/people_page/change_picture.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/people_page_change_picture_test.js
diff --git a/chrome/test/data/webui/settings/people_page_change_picture_test.js b/chrome/test/data/webui/settings/people_page_change_picture_test.js
index acf646b6b3a45091e7770471d0403cc3e5289901..5a20bf976839a21b6a9bc3a78a0872a9fc947d84 100644
--- a/chrome/test/data/webui/settings/people_page_change_picture_test.js
+++ b/chrome/test/data/webui/settings/people_page_change_picture_test.js
@@ -201,6 +201,14 @@ cr.define('settings_people_page_change_picture', function() {
expectEquals(firstDefaultImage, changePicture.selectedItem_);
expectFalse(settingsCamera.cameraActive);
expectTrue(discardControlBar.hidden);
+
+ // Now verify that arrow keys actually select the new image.
+ browserProxy.resetResolver('selectDefaultImage');
+ MockInteractions.pressAndReleaseKeyOn(
+ changePicture.selectedItem_, 39 /* right */);
+ return browserProxy.whenCalled('selectDefaultImage');
+ }).then(function(args) {
+ expectEquals('chrome://foo/2.png', args[0]);
});
});
« no previous file with comments | « chrome/browser/resources/settings/people_page/change_picture.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698