Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2623773002: Ash magnifier: Check whether the caret bounds were actually moved or not. (Closed)

Created:
3 years, 11 months ago by kinaba
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG=673200 TEST=MagnificationControllerTest Review-Url: https://codereview.chromium.org/2562273002 Cr-Commit-Position: refs/heads/master@{#438347} (cherry picked from commit c0105686d120fe7978122cf399061c738de15134) Review-Url: https://codereview.chromium.org/2623773002 . Cr-Commit-Position: refs/branch-heads/2883@{#755} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} Committed: https://chromium.googlesource.com/chromium/src/+/de251a2ef1fefabae9a14ec520a5ca2c1aafe6d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ash/magnifier/magnification_controller.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kinaba
3 years, 11 months ago (2017-01-10 01:52:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de251a2ef1fefabae9a14ec520a5ca2c1aafe6d8.

Powered by Google App Engine
This is Rietveld 408576698