Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 2562273002: Ash magnifier: Check whether the caret bounds were actually moved or not. (Closed)

Created:
4 years ago by kinaba
Modified:
4 years ago
Reviewers:
oshima, jennyz
CC:
chromium-reviews, kalyank, sadrul, Luis Héctor Chávez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ash magnifier: Check whether the caret bounds were actually moved or not. If the caret bounds were not actually moved, do not move the magnification window. Otherwise it causes unnecessary move of focuses. BUG=673200 TEST=MagnificationControllerTest Committed: https://crrev.com/c0105686d120fe7978122cf399061c738de15134 Cr-Commit-Position: refs/heads/master@{#438347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ash/magnifier/magnification_controller.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kinaba
jennyz@ oshima@ PTAL
4 years ago (2016-12-12 03:58:33 UTC) #6
oshima
lgtm
4 years ago (2016-12-13 16:48:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562273002/1
4 years ago (2016-12-13 23:34:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 00:05:29 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 00:07:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0105686d120fe7978122cf399061c738de15134
Cr-Commit-Position: refs/heads/master@{#438347}

Powered by Google App Engine
This is Rietveld 408576698