Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2623743003:
[wasm] Enable WASM by default (--expose-wasm=true). (Closed)
Description[wasm] Enable WASM by default (--expose-wasm=true).
BUG=chromium:575167
R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@chromium.org
Review-Url: https://codereview.chromium.org/2623743003
Cr-Original-Original-Commit-Position: refs/heads/master@{#42197}
Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f
Review-Url: https://codereview.chromium.org/2623743003
Cr-Original-Commit-Position: refs/heads/master@{#42214}
Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346a8a84
Review-Url: https://codereview.chromium.org/2623743003
Cr-Commit-Position: refs/heads/master@{#42267}
Committed: https://chromium.googlesource.com/v8/v8/+/9884fb91e15e5e85218886b67af410668a08c38b
Patch Set 1 #Patch Set 2 : [wasm] Enable WASM by default (--expose-wasm=true). #Patch Set 3 : Disable gc-stress test. #
Messages
Total messages: 38 (22 generated)
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. This is to make the branchpoint for M57.
lgtm
woohoo, lgtm!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
bradnelson@google.com changed reviewers: + bradnelson@google.com
lgtm!
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484075756318570,
"parent_rev": "2aaf217bd05677c9dc8cab7242f698836a830b0a", "commit_rev":
"34b63f050b1a247bb64ddc91c967501ce04e011f"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... ========== to ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2626763002/ by machenbach@chromium.org. The reason for reverting is: arm64 gc stress: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....
Message was sent while issue was closed.
On 2017/01/10 21:03:50, Michael Achenbach wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2626763002/ by mailto:machenbach@chromium.org. > > The reason for reverting is: arm64 gc stress: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%.... If you thing the test is negligible, please disable it...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... ========== to ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... ==========
The CQ bit was checked by titzer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by titzer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from clemensh@chromium.org, ahaas@chromium.org, bradnelson@google.com Link to the patchset: https://codereview.chromium.org/2623743003/#ps40001 (title: "Disable gc-stress test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484129712622870,
"parent_rev": "81700ddfdc579c54e03d4d26fc0331fc13f92aca", "commit_rev":
"71f5650828ffd0162fcd67d9c6ef570a346a8a84"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... ========== to ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346...
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
Hmm, now this breaks a bunch of layout tests and will block rolling: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2621323002/ by machenbach@chromium.org. The reason for reverting is: layout test breakages: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui... revert first to unblock rolling. otherwise please rebaseline..
Message was sent while issue was closed.
Description was changed from ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346... ========== to ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346... ==========
I think the one crasher on v8_linux_blink_rel might not be related to your CL...
The CQ bit was checked by titzer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/12 11:09:09, Michael Achenbach wrote: > I think the one crasher on v8_linux_blink_rel might not be related to your CL... Yeah, I had a look there and didn't see anything related.
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484220752146240,
"parent_rev": "29e6218b7f2e4b9886c80519b0e8443ad2fd93b3", "commit_rev":
"9884fb91e15e5e85218886b67af410668a08c38b"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346... ========== to ========== [wasm] Enable WASM by default (--expose-wasm=true). BUG=chromium:575167 R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@c... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Original-Commit-Position: refs/heads/master@{#42197} Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04... Review-Url: https://codereview.chromium.org/2623743003 Cr-Original-Commit-Position: refs/heads/master@{#42214} Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346... Review-Url: https://codereview.chromium.org/2623743003 Cr-Commit-Position: refs/heads/master@{#42267} Committed: https://chromium.googlesource.com/v8/v8/+/9884fb91e15e5e85218886b67af410668a0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/9884fb91e15e5e85218886b67af410668a0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
