Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2623743003: [wasm] Enable WASM by default (--expose-wasm=true). (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : [wasm] Enable WASM by default (--expose-wasm=true). #

Patch Set 3 : Disable gc-stress test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D test/mjsunit/wasm/no-wasm-by-default.js View 1 chunk +0 lines, -6 lines 0 comments Download
A test/mjsunit/wasm/wasm-default.js View 1 2 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (22 generated)
titzer
PTAL. This is to make the branchpoint for M57.
3 years, 11 months ago (2017-01-10 09:56:19 UTC) #3
ahaas
lgtm
3 years, 11 months ago (2017-01-10 09:56:27 UTC) #4
Clemens Hammacher
woohoo, lgtm!
3 years, 11 months ago (2017-01-10 09:58:45 UTC) #5
bradn
lgtm!
3 years, 11 months ago (2017-01-10 18:39:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623743003/20001
3 years, 11 months ago (2017-01-10 19:16:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f
3 years, 11 months ago (2017-01-10 19:45:03 UTC) #14
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2626763002/ by machenbach@chromium.org. ...
3 years, 11 months ago (2017-01-10 21:03:50 UTC) #15
Michael Achenbach
On 2017/01/10 21:03:50, Michael Achenbach wrote: > A revert of this CL (patchset #2 id:20001) ...
3 years, 11 months ago (2017-01-10 21:05:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623743003/40001
3 years, 11 months ago (2017-01-11 10:15:26 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346a8a84
3 years, 11 months ago (2017-01-11 10:17:28 UTC) #27
Michael Achenbach
Hmm, now this breaks a bunch of layout tests and will block rolling: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12574
3 years, 11 months ago (2017-01-11 12:38:00 UTC) #29
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2621323002/ by machenbach@chromium.org. ...
3 years, 11 months ago (2017-01-11 12:43:16 UTC) #30
Michael Achenbach
I think the one crasher on v8_linux_blink_rel might not be related to your CL...
3 years, 11 months ago (2017-01-12 11:09:09 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623743003/40001
3 years, 11 months ago (2017-01-12 11:32:35 UTC) #34
titzer
On 2017/01/12 11:09:09, Michael Achenbach wrote: > I think the one crasher on v8_linux_blink_rel might ...
3 years, 11 months ago (2017-01-12 11:33:42 UTC) #35
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 12:04:43 UTC) #38
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/9884fb91e15e5e85218886b67af410668a0...

Powered by Google App Engine
This is Rietveld 408576698