Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2621323002: Revert of [wasm] Enable WASM by default (--expose-wasm=true). (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Enable WASM by default (--expose-wasm=true). (patchset #3 id:40001 of https://codereview.chromium.org/2623743003/ ) Reason for revert: layout test breakages: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/12574 revert first to unblock rolling. otherwise please rebaseline. Original issue's description: > [wasm] Enable WASM by default (--expose-wasm=true). > > BUG=chromium:575167 > R=rossberg@chromium.org,ahaas@chromium.org,clemensh@chromium.org,bradnelson@chromium.org > > Review-Url: https://codereview.chromium.org/2623743003 > Cr-Original-Commit-Position: refs/heads/master@{#42197} > Committed: https://chromium.googlesource.com/v8/v8/+/34b63f050b1a247bb64ddc91c967501ce04e011f > Review-Url: https://codereview.chromium.org/2623743003 > Cr-Commit-Position: refs/heads/master@{#42214} > Committed: https://chromium.googlesource.com/v8/v8/+/71f5650828ffd0162fcd67d9c6ef570a346a8a84 TBR=clemensh@chromium.org,ahaas@chromium.org,bradnelson@chromium.org,rossberg@chromium.org,bradnelson@google.com,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2621323002 Cr-Commit-Position: refs/heads/master@{#42222} Committed: https://chromium.googlesource.com/v8/v8/+/96b03dd11161a7bcb584a5600240eb3210263990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download
A test/mjsunit/wasm/no-wasm-by-default.js View 1 chunk +6 lines, -0 lines 0 comments Download
D test/mjsunit/wasm/wasm-default.js View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [wasm] Enable WASM by default (--expose-wasm=true).
3 years, 11 months ago (2017-01-11 12:43:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621323002/1
3 years, 11 months ago (2017-01-11 12:43:28 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:43:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/96b03dd11161a7bcb584a5600240eb32102...

Powered by Google App Engine
This is Rietveld 408576698