Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2623673003: MD WebUI: change all <dialog is="cr-dialog"> to 512px width (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-history_chromium.org, dbeam+watch-elements_chromium.org, dbeam+watch-settings_chromium.org, Patrick Dubroy, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: change all <dialog is="cr-dialog"> to 512px width This should narrow some dialogs in settings, and have no functional affect on history. R=dpapad@chromium.org BUG=640092 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2623673003 Cr-Commit-Position: refs/heads/master@{#442649} Committed: https://chromium.googlesource.com/chromium/src/+/70e75e2c17355305e719485d68c027f9aac7eaf9

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
Dan Beam
3 years, 11 months ago (2017-01-10 05:03:48 UTC) #2
dpapad
LGTM. Don't understand why History's vulcanized.html includes cr-dialog, when that is not used anywhere in ...
3 years, 11 months ago (2017-01-10 17:06:22 UTC) #7
Dan Beam
On 2017/01/10 17:06:22, dpapad wrote: > LGTM. Don't understand why History's vulcanized.html includes cr-dialog, when ...
3 years, 11 months ago (2017-01-10 19:08:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623673003/1
3 years, 11 months ago (2017-01-10 19:08:52 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:14:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/70e75e2c17355305e719485d68c0...

Powered by Google App Engine
This is Rietveld 408576698