Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2621863002: Re-vulcanize Material Design history page (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, calamity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-vulcanize Material Design history page R=tsergeant@chromium.org BUG=653398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2623673003 Patch 1

Messages

Total messages: 13 (8 generated)
Dan Beam
3 years, 11 months ago (2017-01-10 02:12:45 UTC) #2
tsergeant
lgtm
3 years, 11 months ago (2017-01-10 02:19:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2621863002/1
3 years, 11 months ago (2017-01-10 04:32:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/338144)
3 years, 11 months ago (2017-01-10 05:12:19 UTC) #11
Dan Beam
3 years, 11 months ago (2017-01-10 05:20:51 UTC) #13
Message was sent while issue was closed. 
this already landed here:
https://codereview.chromium.org/2620613003/diff/1/chrome/browser/resources/md...

the git-commit-patch error message was also "working tree is clean", meaning a
patch was applied but there was nothing changed

closing

Powered by Google App Engine
This is Rietveld 408576698