Set proper action name on Pay Intent

Set proper action name on Pay Intent

Set proper action name on Pay Intent, this will be useful
for the Activity to distinguish between the actions listed
in the intent filters.

BUG=620173
Review-Url: https://codereview.chromium.org/2623553002
Cr-Commit-Position: refs/heads/master@{#442306}
Committed: https://chromium.googlesource.com/chromium/src/+/939b4423ee7c5c20e44de09c350ebcf61286b749

[rwlbuis, 2017-01-09 18:11:00]

rob.buis@samsung.com changed reviewers:
+ rouslan@chromium.org

[rwlbuis, 2017-01-09 18:11:01]

PTAL, this one should be easy :) I verified that BobPay still works after this
change.

[please use gerrit instead, 2017-01-09 18:14:03]

Thank you for the patch!

https://codereview.chromium.org/2623553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2623553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:39:
private static final String PAY_INTENT_ACTION =
"org.chromium.intent.action.PAY";
Please make this strict public and use it in AndroidPaymentAppFactory as well.
Keep in mind that intent names should start with the word ACTION_ instead of
ending on _ACTION and that public constants should have JavaDoc and be listed
above private constants.

[please use gerrit instead, 2017-01-09 18:14:24]

On 2017/01/09 18:14:03, rouslan wrote:
> Please make this strict public and use it in AndroidPaymentAppFactory as well.

s/strict/constant/

[rwlbuis, 2017-01-09 18:32:54]

https://codereview.chromium.org/2623553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2623553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:39:
private static final String PAY_INTENT_ACTION =
"org.chromium.intent.action.PAY";
On 2017/01/09 18:14:03, rouslan wrote:
> Please make this strict public and use it in AndroidPaymentAppFactory as well.
> Keep in mind that intent names should start with the word ACTION_ instead of
> ending on _ACTION and that public constants should have JavaDoc and be listed
> above private constants.

Done.

[please use gerrit instead, 2017-01-09 18:33:36]

lgtm

[rwlbuis, 2017-01-09 18:43:17]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2017-01-09 18:43:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:15:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483987397467010,
"parent_rev": "00441ebd3bba98a56ad4a44b1589cbf22803fe38", "commit_rev":
"939b4423ee7c5c20e44de09c350ebcf61286b749"}

[commit-bot: I haz the power, 2017-01-09 19:16:28]

Description was changed from

==========
Set proper action name on Pay Intent

Set proper action name on Pay Intent, this will be useful
for the Activity to distinguish between the actions listed
in the intent filters.

BUG=620173
==========

to

==========
Set proper action name on Pay Intent

Set proper action name on Pay Intent, this will be useful
for the Activity to distinguish between the actions listed
in the intent filters.

BUG=620173

Review-Url: https://codereview.chromium.org/2623553002
Cr-Commit-Position: refs/heads/master@{#442306}
Committed:
https://chromium.googlesource.com/chromium/src/+/939b4423ee7c5c20e44de09c350e...
==========

[commit-bot: I haz the power, 2017-01-09 19:16:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/939b4423ee7c5c20e44de09c350e...