Set proper action name on Pay Intent

chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.app.Activity;
 import android.content.Intent;
 import android.graphics.drawable.Drawable;
 import android.os.Bundle;
@@ skipping 18 matching lines @@
 
 /** The point of interaction with a locally installed 3rd party native Android payment app. */
 public class AndroidPaymentApp extends PaymentInstrument implements PaymentApp,
         WindowAndroid.IntentCallback {
     private static final String EXTRA_METHOD_NAME = "methodName";
     private static final String EXTRA_DATA = "data";
     private static final String EXTRA_ORIGIN = "origin";
     private static final String EXTRA_DETAILS = "details";
     private static final String EXTRA_INSTRUMENT_DETAILS = "instrumentDetails";
     private static final String EMPTY_JSON_DATA = "{}";
+    private static final String PAY_INTENT_ACTION = "org.chromium.intent.action.PAY";

[please use gerrit instead, 2017/01/09 18:14:03]

Please make this strict public and use it in AndroidPaymentAppFactory as well.
Keep in mind that intent names should start with the word ACTION_ instead of
ending on _ACTION and that public constants should have JavaDoc and be listed
above private constants.

[rwlbuis, 2017/01/09 18:32:54]

Done.

 
     private final Handler mHandler;
     private final WebContents mWebContents;
     private final Intent mPayIntent;
     private final Set<String> mMethodNames;
     private String mIsReadyToPayService;
     private InstrumentDetailsCallback mInstrumentDetailsCallback;
 
     /**
      * Builds the point of interaction with a locally installed 3rd party native Android payment
      * app.
      *
      * @param webContents The web contents.
      * @param packageName The name of the package of the payment app.
      * @param activity    The name of the payment activity in the payment app.
      * @param label       The UI label to use for the payment app.
      * @param icon        The icon to use in UI for the payment app.
      */
     public AndroidPaymentApp(WebContents webContents, String packageName, String activity,
             String label, Drawable icon) {
         super(packageName, label, null, icon);
         mHandler = new Handler();
         mWebContents = webContents;
         mPayIntent = new Intent();
         mPayIntent.setClassName(packageName, activity);
+        mPayIntent.setAction(PAY_INTENT_ACTION);
         mMethodNames = new HashSet<>();
     }
 
     /** @param methodName A payment method that this app supports, e.g., "https://bobpay.com". */
     public void addMethodName(String methodName) {
         mMethodNames.add(methodName);
     }
 
     /** @param service The name of the "is ready to pay" service in the payment app. */
     public void setIsReadyToPayService(String service) {
@@ skipping 139 matching lines @@
             mInstrumentDetailsCallback.onInstrumentDetailsReady(
                     data.getExtras().getString(EXTRA_METHOD_NAME),
                     data.getExtras().getString(EXTRA_INSTRUMENT_DETAILS));
         }
         mInstrumentDetailsCallback = null;
     }
 
     @Override
     public void dismissInstrument() {}
 }