Support tracking focused node element for OOPIFs.

Support tracking focused node element for OOPIFs.

Focused elements are tracked by RenderViewHostImpl. Upon a change in focused
element, RenderViewImpl sends ViewHostMsg_FocusedNodeChanged to the browser.

With --site-per-process, RenderViewImpl corresponding to OOPIFs is swapped
out and cannot send the IPC. Even by allowing sending such IPCs in swapped
out state, the RenderViewHost cannot properly handle them when there are
multiple RenderWidgetHosts (same process) on the page. This is now causing
regressions with OSK for windows tablets.

This CL will move the logic from RenderViewImpl to RenderFrameImpl.
When focus moves from one WebNode to another, the corresponding frames are
already getting notified by RenderViewImpl. This CL relieves RenderViewImpl
from sending the IPC, and reuses the RenderFrameImpl::FocusNodeChanged() for
sending the update to RenderFrameHostImpl, which then stores the state and
notifies its delegate (WebContentsImpl) about the change.

For similar reasons, the logic to update FocusedNodeTouched is removed from
RenderViewImpl to RenderWidget and is now handled by RenderWidgetHostImpl.

The public API methods in RenderViewHost are unchanged but they are now
handled through RenderViewHostDelegate (WebContentsImpl), which will
query the information or send the command through the focused frame.

BUG=613326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2571583008
Cr-Commit-Position: refs/heads/master@{#440185}
(cherry picked from commit a110f64a89bad15abb5322be8e720fae40a0f7f1)

Review-Url: https://codereview.chromium.org/2623483003
Cr-Commit-Position: refs/branch-heads/2924@{#717}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/5148b7c299c9adc09ca11cce1b16fe33febf749e

[EhsanK, 2017-01-10 00:21:48]

Description was changed from

==========
Support tracking focused node element for OOPIFs.

Focused elements are tracked by RenderViewHostImpl. Upon a change in focused
element, RenderViewImpl sends ViewHostMsg_FocusedNodeChanged to the browser.

With --site-per-process, RenderViewImpl corresponding to OOPIFs is swapped
out and cannot send the IPC. Even by allowing sending such IPCs in swapped
out state, the RenderViewHost cannot properly handle them when there are
multiple RenderWidgetHosts (same process) on the page. This is now causing
regressions with OSK for windows tablets.

This CL will move the logic from RenderViewImpl to RenderFrameImpl.
When focus moves from one WebNode to another, the corresponding frames are
already getting notified by RenderViewImpl. This CL relieves RenderViewImpl
from sending the IPC, and reuses the RenderFrameImpl::FocusNodeChanged() for
sending the update to RenderFrameHostImpl, which then stores the state and
notifies its delegate (WebContentsImpl) about the change.

For similar reasons, the logic to update FocusedNodeTouched is removed from
RenderViewImpl to RenderWidget and is now handled by RenderWidgetHostImpl.

The public API methods in RenderViewHost are unchanged but they are now
handled through RenderViewHostDelegate (WebContentsImpl), which will
query the information or send the command through the focused frame.

BUG=613326
TBR=creis@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2571583008
Cr-Commit-Position: refs/heads/master@{#440185}
(cherry picked from commit a110f64a89bad15abb5322be8e720fae40a0f7f1)
==========

to

==========
Support tracking focused node element for OOPIFs.

Focused elements are tracked by RenderViewHostImpl. Upon a change in focused
element, RenderViewImpl sends ViewHostMsg_FocusedNodeChanged to the browser.

With --site-per-process, RenderViewImpl corresponding to OOPIFs is swapped
out and cannot send the IPC. Even by allowing sending such IPCs in swapped
out state, the RenderViewHost cannot properly handle them when there are
multiple RenderWidgetHosts (same process) on the page. This is now causing
regressions with OSK for windows tablets.

This CL will move the logic from RenderViewImpl to RenderFrameImpl.
When focus moves from one WebNode to another, the corresponding frames are
already getting notified by RenderViewImpl. This CL relieves RenderViewImpl
from sending the IPC, and reuses the RenderFrameImpl::FocusNodeChanged() for
sending the update to RenderFrameHostImpl, which then stores the state and
notifies its delegate (WebContentsImpl) about the change.

For similar reasons, the logic to update FocusedNodeTouched is removed from
RenderViewImpl to RenderWidget and is now handled by RenderWidgetHostImpl.

The public API methods in RenderViewHost are unchanged but they are now
handled through RenderViewHostDelegate (WebContentsImpl), which will
query the information or send the command through the focused frame.

BUG=613326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2571583008
Cr-Commit-Position: refs/heads/master@{#440185}
(cherry picked from commit a110f64a89bad15abb5322be8e720fae40a0f7f1)
==========

[EhsanK, 2017-01-10 00:22:50]

Hi Charlie,

There were some merge conflicts so I did this one manually. I am locally
compiling to make sure everything is OK.

Meanwhile, PTAL.

PS: I will probably CQ this tomorrow after testing it.

[Charlie Reis, 2017-01-10 00:50:31]

On 2017/01/10 00:22:50, EhsanK wrote:
> Hi Charlie,
> 
> There were some merge conflicts so I did this one manually. I am locally
> compiling to make sure everything is OK.
> 
> Meanwhile, PTAL.
> 
> PS: I will probably CQ this tomorrow after testing it.

Were the merge conflicts in render_frame_host_impl.h,
render_widget_host_delegate.h, and web_contents_impl.{h,cc}?  Those seem
straightforward enough, assuming they compile and pass the test you added. 
Merge LGTM.

[EhsanK, 2017-01-10 17:35:23]

Thanks Charlie!

The last patch compiles just fine on Linux and Windows. I verified the build on
Windows 8 again and it fixes the OSK issue.

The conflicts were on files frame_messages.h, web_contents.h/cc and
render_widget_host_delegate.h.

There was a missing forward declaration of RenderFrameHostImpl from
render_frame_host_delegate.h which I added in the last patch.

Committing now.

[EhsanK, 2017-01-10 17:35:28]

The CQ bit was checked by ekaramad@chromium.org

[EhsanK, 2017-01-10 17:35:29]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2623483003/#ps40001
(title: "Added the missing forward declaration")

[commit-bot: I haz the power, 2017-01-10 17:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 17:37:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484069728880130,
"parent_rev": "f2abb45a480c9efd4dfa7c3c79fbffa942cde58f", "commit_rev":
"5148b7c299c9adc09ca11cce1b16fe33febf749e"}

[commit-bot: I haz the power, 2017-01-10 17:38:19]

Description was changed from

==========
Support tracking focused node element for OOPIFs.

Focused elements are tracked by RenderViewHostImpl. Upon a change in focused
element, RenderViewImpl sends ViewHostMsg_FocusedNodeChanged to the browser.

With --site-per-process, RenderViewImpl corresponding to OOPIFs is swapped
out and cannot send the IPC. Even by allowing sending such IPCs in swapped
out state, the RenderViewHost cannot properly handle them when there are
multiple RenderWidgetHosts (same process) on the page. This is now causing
regressions with OSK for windows tablets.

This CL will move the logic from RenderViewImpl to RenderFrameImpl.
When focus moves from one WebNode to another, the corresponding frames are
already getting notified by RenderViewImpl. This CL relieves RenderViewImpl
from sending the IPC, and reuses the RenderFrameImpl::FocusNodeChanged() for
sending the update to RenderFrameHostImpl, which then stores the state and
notifies its delegate (WebContentsImpl) about the change.

For similar reasons, the logic to update FocusedNodeTouched is removed from
RenderViewImpl to RenderWidget and is now handled by RenderWidgetHostImpl.

The public API methods in RenderViewHost are unchanged but they are now
handled through RenderViewHostDelegate (WebContentsImpl), which will
query the information or send the command through the focused frame.

BUG=613326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2571583008
Cr-Commit-Position: refs/heads/master@{#440185}
(cherry picked from commit a110f64a89bad15abb5322be8e720fae40a0f7f1)
==========

to

==========
Support tracking focused node element for OOPIFs.

Focused elements are tracked by RenderViewHostImpl. Upon a change in focused
element, RenderViewImpl sends ViewHostMsg_FocusedNodeChanged to the browser.

With --site-per-process, RenderViewImpl corresponding to OOPIFs is swapped
out and cannot send the IPC. Even by allowing sending such IPCs in swapped
out state, the RenderViewHost cannot properly handle them when there are
multiple RenderWidgetHosts (same process) on the page. This is now causing
regressions with OSK for windows tablets.

This CL will move the logic from RenderViewImpl to RenderFrameImpl.
When focus moves from one WebNode to another, the corresponding frames are
already getting notified by RenderViewImpl. This CL relieves RenderViewImpl
from sending the IPC, and reuses the RenderFrameImpl::FocusNodeChanged() for
sending the update to RenderFrameHostImpl, which then stores the state and
notifies its delegate (WebContentsImpl) about the change.

For similar reasons, the logic to update FocusedNodeTouched is removed from
RenderViewImpl to RenderWidget and is now handled by RenderWidgetHostImpl.

The public API methods in RenderViewHost are unchanged but they are now
handled through RenderViewHostDelegate (WebContentsImpl), which will
query the information or send the command through the focused frame.

BUG=613326
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2571583008
Cr-Commit-Position: refs/heads/master@{#440185}
(cherry picked from commit a110f64a89bad15abb5322be8e720fae40a0f7f1)

Review-Url: https://codereview.chromium.org/2623483003
Cr-Commit-Position: refs/branch-heads/2924@{#717}
Cr-Branched-From:
3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed:
https://chromium.googlesource.com/chromium/src/+/5148b7c299c9adc09ca11cce1b16...
==========

[commit-bot: I haz the power, 2017-01-10 17:38:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5148b7c299c9adc09ca11cce1b16...