Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2623483003: Support tracking focused node element for OOPIFs. (Closed)
Patch Set: Added the missing forward declaration Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 0c11c301552002fbe814cde77704144a6c9b6e31..56ad11570903349637d397df049f18e17825e1c3 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1195,7 +1195,6 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
OnEnumerateDirectoryResponse)
IPC_MESSAGE_HANDLER(ViewMsg_ClosePage, OnClosePage)
IPC_MESSAGE_HANDLER(ViewMsg_MoveOrResizeStarted, OnMoveOrResizeStarted)
- IPC_MESSAGE_HANDLER(ViewMsg_ClearFocusedElement, OnClearFocusedElement)
IPC_MESSAGE_HANDLER(ViewMsg_SetBackgroundOpaque, OnSetBackgroundOpaque)
IPC_MESSAGE_HANDLER(ViewMsg_EnablePreferredSizeChangedMode,
OnEnablePreferredSizeChangedMode)
@@ -1699,18 +1698,6 @@ void RenderViewImpl::focusedNodeChanged(const WebNode& fromNode,
const WebNode& toNode) {
has_scrolled_focused_editable_node_into_rect_ = false;
- gfx::Rect node_bounds;
- bool is_editable = false;
- if (!toNode.isNull() && toNode.isElementNode()) {
- WebElement element = const_cast<WebNode&>(toNode).to<WebElement>();
- blink::WebRect rect = element.boundsInViewport();
- ConvertViewportToWindowViaWidget(&rect);
- node_bounds = gfx::Rect(rect);
- is_editable = element.isEditable();
- }
- Send(new ViewHostMsg_FocusedNodeChanged(GetRoutingID(), is_editable,
- node_bounds));
-
// TODO(estade): remove.
for (auto& observer : observers_)
observer.FocusedNodeChanged(toNode);
@@ -1815,20 +1802,6 @@ void RenderViewImpl::didHandleGestureEvent(
for (auto& observer : observers_)
observer.DidHandleGestureEvent(event);
}
-
- // TODO(ananta): Piggyback off existing IPCs to communicate this information,
- // crbug/420130.
-#if defined(OS_WIN)
- if (event.type != blink::WebGestureEvent::GestureTap)
- return;
-
- // TODO(estade): hit test the event against focused node to make sure
- // the tap actually hit the focused node.
- blink::WebTextInputType text_input_type = GetWebView()->textInputType();
-
- Send(new ViewHostMsg_FocusedNodeTouched(
- GetRoutingID(), text_input_type != blink::WebTextInputTypeNone));
-#endif
}
void RenderViewImpl::initializeLayerTreeView() {
@@ -2296,11 +2269,6 @@ void RenderViewImpl::OnResize(const ResizeParams& params) {
has_scrolled_focused_editable_node_into_rect_ = false;
}
-void RenderViewImpl::OnClearFocusedElement() {
- if (webview())
- webview()->clearFocusedElement();
-}
-
void RenderViewImpl::OnSetBackgroundOpaque(bool opaque) {
if (frame_widget_)
frame_widget_->setIsTransparent(!opaque);
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698