Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2623423003: [LayoutNG] Put #includes in alphabetical order. (Closed)

Created:
3 years, 11 months ago by mstensho (USE GERRIT)
Modified:
3 years, 11 months ago
Reviewers:
atotic, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Put #includes in alphabetical order. Review-Url: https://codereview.chromium.org/2623423003 Cr-Commit-Position: refs/heads/master@{#443279} Committed: https://chromium.googlesource.com/chromium/src/+/f38ee194e671002a245a2a2c0c52cc7b0a762da1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -33 lines) Patch
M third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_box_fragment.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_line_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_fragment.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_text_layout_algorithm.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
I guess the Source/core/layout/ng/PRESUBMIT.py override causes this check to be skipped when uploading CLs.
3 years, 11 months ago (2017-01-12 11:57:52 UTC) #6
eae
RS-LGTM
3 years, 11 months ago (2017-01-12 17:32:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623423003/1
3 years, 11 months ago (2017-01-12 17:33:40 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:40:34 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f38ee194e671002a245a2a2c0c52...

Powered by Google App Engine
This is Rietveld 408576698