Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2623383002: Revert of [wasm][asm.js] Do same work even when not printing asm info. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
bradn, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm][asm.js] Do same work even when not printing asm info. (patchset #1 id:1 of https://codereview.chromium.org/2629043002/ ) Reason for revert: Triggers flaky tests. Original issue's description: > [wasm][asm.js] Do same work even when not printing asm info. > > Skipping this work seems to perturb a gc-stress issue. > More investigation is likely needed. > > BUG=v8:4203 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2629043002 > Cr-Commit-Position: refs/heads/master@{#42248} > Committed: https://chromium.googlesource.com/v8/v8/+/785cedf1ee6671399c2b2b7f6c6a8119f55195b4 TBR=danno@chromium.org,bradnelson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2623383002 Cr-Commit-Position: refs/heads/master@{#42252} Committed: https://chromium.googlesource.com/v8/v8/+/f5f22cfc581a6bc52275053c0ce4d5e7cc2ad9f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -34 lines) Patch
M src/asmjs/asm-js.cc View 2 chunks +41 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bradnelson
Created Revert of [wasm][asm.js] Do same work even when not printing asm info.
3 years, 11 months ago (2017-01-12 01:58:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623383002/1
3 years, 11 months ago (2017-01-12 01:58:41 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 01:59:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f5f22cfc581a6bc52275053c0ce4d5e7cc2...

Powered by Google App Engine
This is Rietveld 408576698