Adding check to ensure onboarding content is not shown to supervised users.

Adding check to ensure onboarding content is not shown to supervised users.

BUG=680076
Review-Url: https://codereview.chromium.org/2623253002
Cr-Commit-Position: refs/heads/master@{#443420}
Committed: https://chromium.googlesource.com/chromium/src/+/a27abc1cedbf0f585c5e2830beadebf1cc2b52cb

[tmartino, 2017-01-11 17:04:05]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:38:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:38:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tmartino, 2017-01-11 19:03:23]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:47:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tmartino, 2017-01-11 19:53:21]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 19:54:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-01-11 20:43:28]

tmartino@chromium.org changed reviewers:
+ pkasting@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:50:35]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-01-12 18:28:19]

LGTM

https://codereview.chromium.org/2623253002/diff/40001/chrome/browser/ui/start...
File chrome/browser/ui/startup/startup_tab_provider.h (right):

https://codereview.chromium.org/2623253002/diff/40001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_tab_provider.h:67: bool is_supervised_user);
Random muse: It seems like there are now a number of places in the startup code
that pass a bunch of bools around.  I wonder if any of these would read more
clearly (and safely) at callers/test sites if they used enums, or passed a
struct with named members, or something.

[tmartino, 2017-01-12 22:49:39]

On 2017/01/12 at 18:28:19, pkasting wrote:
> LGTM
> 
>
https://codereview.chromium.org/2623253002/diff/40001/chrome/browser/ui/start...
> File chrome/browser/ui/startup/startup_tab_provider.h (right):
> 
>
https://codereview.chromium.org/2623253002/diff/40001/chrome/browser/ui/start...
> chrome/browser/ui/startup/startup_tab_provider.h:67: bool is_supervised_user);
> Random muse: It seems like there are now a number of places in the startup
code that pass a bunch of bools around.  I wonder if any of these would read
more clearly (and safely) at callers/test sites if they used enums, or passed a
struct with named members, or something.

Yeah, this is getting to be a fairly long arg-list. I'll keep that in mind for a
pending CL.

[tmartino, 2017-01-12 22:49:41]

The CQ bit was checked by tmartino@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:50:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:49:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484261381717840,
"parent_rev": "8b7f961697115ebfa0dc4eb98a98ff0ab3d1c4a8", "commit_rev":
"a27abc1cedbf0f585c5e2830beadebf1cc2b52cb"}

[commit-bot: I haz the power, 2017-01-13 00:49:32]

Description was changed from

==========
Adding check to ensure onboarding content is not shown to supervised users.

BUG=680076
==========

to

==========
Adding check to ensure onboarding content is not shown to supervised users.

BUG=680076

Review-Url: https://codereview.chromium.org/2623253002
Cr-Commit-Position: refs/heads/master@{#443420}
Committed:
https://chromium.googlesource.com/chromium/src/+/a27abc1cedbf0f585c5e2830bead...
==========

[commit-bot: I haz the power, 2017-01-13 00:49:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a27abc1cedbf0f585c5e2830bead...