Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Issue 2623253002: Adding check to ensure onboarding content is not shown to supervised users. (Closed)
Patch Set: Fixing Win double define Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/startup/startup_tab_provider.h" 5 #include "chrome/browser/ui/startup/startup_tab_provider.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/common/url_constants.h" 8 #include "chrome/common/url_constants.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
11 11
12 TEST(StartupTabProviderTest, CheckStandardOnboardingTabPolicy) { 12 TEST(StartupTabProviderTest, CheckStandardOnboardingTabPolicy) {
13 // Show welcome page to new unauthenticated profile on first run. 13 // Show welcome page to new unauthenticated profile on first run.
14 StartupTabs output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy( 14 StartupTabs output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
15 true, false, false); 15 true, false, false, false);
16 16
17 ASSERT_EQ(1U, output.size()); 17 ASSERT_EQ(1U, output.size());
18 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url); 18 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
19 EXPECT_FALSE(output[0].is_pinned); 19 EXPECT_FALSE(output[0].is_pinned);
20 20
21 // After first run, display welcome page using variant view. 21 // After first run, display welcome page using variant view.
22 output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy( 22 output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
23 false, false, false); 23 false, false, false, false);
24 24
25 ASSERT_EQ(1U, output.size()); 25 ASSERT_EQ(1U, output.size());
26 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(true), output[0].url); 26 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(true), output[0].url);
27 EXPECT_FALSE(output[0].is_pinned); 27 EXPECT_FALSE(output[0].is_pinned);
28 } 28 }
29 29
30 TEST(StartupTabProviderTest, CheckStandardOnboardingTabPolicy_Negative) { 30 TEST(StartupTabProviderTest, CheckStandardOnboardingTabPolicy_Negative) {
31 // Do not show the welcome page to the same profile twice. 31 // Do not show the welcome page to the same profile twice.
32 StartupTabs output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy( 32 StartupTabs output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
33 true, true, false); 33 true, true, false, false);
34 34
35 EXPECT_TRUE(output.empty()); 35 EXPECT_TRUE(output.empty());
36 36
37 // Do not show the welcome page to authenticated users. 37 // Do not show the welcome page to authenticated users.
38 output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(true, false, 38 output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
39 true); 39 true, false, true, false);
40
41 EXPECT_TRUE(output.empty());
42
43 // Do not show the welcome page to supervised users.
44 output = StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
45 true, false, false, true);
40 46
41 EXPECT_TRUE(output.empty()); 47 EXPECT_TRUE(output.empty());
42 } 48 }
43 49
44 #if defined(OS_WIN) 50 #if defined(OS_WIN)
45 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy) { 51 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy) {
46 // Show Win 10 Welcome page if it has not been seen, but the standard page 52 // Show Win 10 Welcome page if it has not been seen, but the standard page
47 // has. 53 // has.
48 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 54 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
49 true, true, false, false, true, false); 55 true, true, false, false, true, false, false);
50 56
51 ASSERT_EQ(1U, output.size()); 57 ASSERT_EQ(1U, output.size());
52 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false), 58 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false),
53 output[0].url); 59 output[0].url);
54 EXPECT_FALSE(output[0].is_pinned); 60 EXPECT_FALSE(output[0].is_pinned);
55 61
56 // Show standard Welcome page if the Win 10 Welcome page has been seen, but 62 // Show standard Welcome page if the Win 10 Welcome page has been seen, but
57 // the standard page has not. 63 // the standard page has not.
58 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 64 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
59 true, false, true, false, true, false); 65 true, false, true, false, true, false, false);
60 66
61 ASSERT_EQ(1U, output.size()); 67 ASSERT_EQ(1U, output.size());
62 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url); 68 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
63 EXPECT_FALSE(output[0].is_pinned); 69 EXPECT_FALSE(output[0].is_pinned);
64 70
65 // If neither page has been seen, the Win 10 Welcome page takes precedence 71 // If neither page has been seen, the Win 10 Welcome page takes precedence
66 // this launch. 72 // this launch.
67 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 73 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
68 true, false, false, false, true, false); 74 true, false, false, false, true, false, false);
69 75
70 ASSERT_EQ(1U, output.size()); 76 ASSERT_EQ(1U, output.size());
71 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false), 77 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false),
72 output[0].url); 78 output[0].url);
73 EXPECT_FALSE(output[0].is_pinned); 79 EXPECT_FALSE(output[0].is_pinned);
74 } 80 }
75 81
76 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_LaterRunVariant) { 82 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_LaterRunVariant) {
77 // Show a variant of the Win 10 Welcome page after first run, if it has not 83 // Show a variant of the Win 10 Welcome page after first run, if it has not
78 // been seen. 84 // been seen.
79 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 85 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
80 false, false, false, false, true, false); 86 false, false, false, false, true, false, false);
81 87
82 ASSERT_EQ(1U, output.size()); 88 ASSERT_EQ(1U, output.size());
83 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(true), 89 EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(true),
84 output[0].url); 90 output[0].url);
85 EXPECT_FALSE(output[0].is_pinned); 91 EXPECT_FALSE(output[0].is_pinned);
86 92
87 // Show a variant of the standard Welcome page after first run, if the Win 10 93 // Show a variant of the standard Welcome page after first run, if the Win 10
88 // Welcome page has already been seen but the standard has not. 94 // Welcome page has already been seen but the standard has not.
89 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 95 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
90 false, false, true, false, true, false); 96 false, false, true, false, true, false, false);
91 97
92 ASSERT_EQ(1U, output.size()); 98 ASSERT_EQ(1U, output.size());
93 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(true), output[0].url); 99 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(true), output[0].url);
94 EXPECT_FALSE(output[0].is_pinned); 100 EXPECT_FALSE(output[0].is_pinned);
95 } 101 }
96 102
97 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_Negative) { 103 TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_Negative) {
98 // Do not show either page if it has already been shown. 104 // Do not show either page if it has already been shown.
99 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 105 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
100 true, true, true, false, true, false); 106 true, true, true, false, true, false, false);
107
108 EXPECT_TRUE(output.empty());
109
110 // Do not show either page to supervised users.
111 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
112 true, false, false, false, true, false, true);
101 113
102 EXPECT_TRUE(output.empty()); 114 EXPECT_TRUE(output.empty());
103 115
104 // If Chrome is already the default browser, don't show the Win 10 Welcome 116 // If Chrome is already the default browser, don't show the Win 10 Welcome
105 // page, and don't preempt the standard Welcome page. 117 // page, and don't preempt the standard Welcome page.
106 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 118 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
107 true, false, false, false, true, true); 119 true, false, false, false, true, true, false);
108 120
109 ASSERT_EQ(1U, output.size()); 121 ASSERT_EQ(1U, output.size());
110 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url); 122 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
111 EXPECT_FALSE(output[0].is_pinned); 123 EXPECT_FALSE(output[0].is_pinned);
112 124
113 // If the user is signed in, block showing the standard Welcome page. 125 // If the user is signed in, block showing the standard Welcome page.
114 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 126 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
115 true, false, true, true, true, false); 127 true, false, true, true, true, false, false);
116 128
117 EXPECT_TRUE(output.empty()); 129 EXPECT_TRUE(output.empty());
118 } 130 }
119 131
120 TEST(StartupTabProviderTest, 132 TEST(StartupTabProviderTest,
121 CheckWin10OnboardingTabPolicy_SetDefaultBrowserNotAllowed) { 133 CheckWin10OnboardingTabPolicy_SetDefaultBrowserNotAllowed) {
122 // Skip the Win 10 promo if setting the default browser is not allowed. 134 // Skip the Win 10 promo if setting the default browser is not allowed.
123 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 135 StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
124 true, false, false, false, false, false); 136 true, false, false, false, false, false, false);
125 137
126 ASSERT_EQ(1U, output.size()); 138 ASSERT_EQ(1U, output.size());
127 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url); 139 EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
128 140
129 // After first run, no onboarding content is displayed when setting the 141 // After first run, no onboarding content is displayed when setting the
130 // default browser is not allowed. 142 // default browser is not allowed.
131 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy( 143 output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
132 true, true, false, false, false, false); 144 true, true, false, false, false, false, false);
133 145
134 EXPECT_TRUE(output.empty()); 146 EXPECT_TRUE(output.empty());
135 } 147 }
136 148
137 #endif 149 #endif
138 150
139 TEST(StartupTabProviderTest, CheckMasterPrefsTabPolicy) { 151 TEST(StartupTabProviderTest, CheckMasterPrefsTabPolicy) {
140 std::vector<GURL> input = {GURL(base::ASCIIToUTF16("https://new_tab_page")), 152 std::vector<GURL> input = {GURL(base::ASCIIToUTF16("https://new_tab_page")),
141 GURL(base::ASCIIToUTF16("https://www.google.com")), 153 GURL(base::ASCIIToUTF16("https://www.google.com")),
142 GURL(base::ASCIIToUTF16("https://welcome_page"))}; 154 GURL(base::ASCIIToUTF16("https://welcome_page"))};
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 } 273 }
262 274
263 TEST(StartupTabProviderTest, CheckNewTabPageTabPolicy_Negative) { 275 TEST(StartupTabProviderTest, CheckNewTabPageTabPolicy_Negative) {
264 SessionStartupPref pref_last(SessionStartupPref::Type::LAST); 276 SessionStartupPref pref_last(SessionStartupPref::Type::LAST);
265 277
266 StartupTabs output = 278 StartupTabs output =
267 StartupTabProviderImpl::CheckNewTabPageTabPolicy(pref_last); 279 StartupTabProviderImpl::CheckNewTabPageTabPolicy(pref_last);
268 280
269 ASSERT_TRUE(output.empty()); 281 ASSERT_TRUE(output.empty());
270 } 282 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698