Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2623063002: Revert of Sub-sample accurate start of OscillatorNode (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
Reviewers:
hongchan, Raymond Toy
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sub-sample accurate start of OscillatorNode (patchset #11 id:200001 of https://codereview.chromium.org/2186813003/ ) Reason for revert: Added test is failing on WebKit Mac10.11 (retina) https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 Original issue's description: > Sub-sample accurate start of OscillatorNode > > Previously, an oscillator would start at the nearest sample frame > boundary. This can produce noticeable effects. > > Instead, make the oscillator start at the requested sample time and > sample the curve appropriately. > > BUG=631576 > TEST=Oscillator/start-sampling.html > > Review-Url: https://codereview.chromium.org/2186813003 > Cr-Commit-Position: refs/heads/master@{#442669} > Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c TBR=hongchan@chromium.org,rtoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631576 Review-Url: https://codereview.chromium.org/2623063002 Cr-Commit-Position: refs/heads/master@{#442739} Committed: https://chromium.googlesource.com/chromium/src/+/30ffb0ffee307ed4f236bd3df8398bf0c1b107c4

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Timothy Loh
Created Revert of Sub-sample accurate start of OscillatorNode
3 years, 11 months ago (2017-01-11 00:20:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623063002/1
3 years, 11 months ago (2017-01-11 00:20:47 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 00:22:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30ffb0ffee307ed4f236bd3df839...

Powered by Google App Engine
This is Rietveld 408576698