Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/122137)
4 years, 4 months ago
(2016-08-12 23:47:12 UTC)
#8
Description was changed from ========== Sub-sample accurate start of OscillatorNode Previously, an oscillator would start ...
3 years, 11 months ago
(2017-01-05 16:39:52 UTC)
#18
Description was changed from
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=osc-start-sampling.html
==========
to
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=Oscillator/start-sampling.html
==========
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186813003/180001
3 years, 11 months ago
(2017-01-05 16:39:59 UTC)
#19
3 years, 11 months ago
(2017-01-05 20:27:26 UTC)
#23
Dry run: This issue passed the CQ dry run.
hongchan
lgtm https://codereview.chromium.org/2186813003/diff/180001/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html File third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html (right): https://codereview.chromium.org/2186813003/diff/180001/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html#newcode16 third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html:16: var defaultSampleRate = 24000; This is a new ...
3 years, 11 months ago
(2017-01-05 23:48:06 UTC)
#24
CQ is committing da patch. Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484071023081100, "parent_rev": "8eb71cdc6259464bee1640d4acdefb9638088e40", "commit_rev": "7909df464ca46a1ea121b0c54e5d04cfa521e38c"}
3 years, 11 months ago
(2017-01-10 20:17:33 UTC)
#29
CQ is committing da patch.
Bot data: {"patchset_id": 200001, "attempt_start_ts": 1484071023081100,
"parent_rev": "8eb71cdc6259464bee1640d4acdefb9638088e40", "commit_rev":
"7909df464ca46a1ea121b0c54e5d04cfa521e38c"}
commit-bot: I haz the power
Description was changed from ========== Sub-sample accurate start of OscillatorNode Previously, an oscillator would start ...
3 years, 11 months ago
(2017-01-10 20:18:03 UTC)
#30
Message was sent while issue was closed.
Description was changed from
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=Oscillator/start-sampling.html
==========
to
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=Oscillator/start-sampling.html
Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#442669}
Committed:
https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d...
==========
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c
3 years, 11 months ago
(2017-01-10 20:18:05 UTC)
#31
On 2017/01/11 00:20:15, Timothy Loh wrote: > A revert of this CL (patchset #11 id:200001) ...
3 years, 11 months ago
(2017-01-11 16:44:29 UTC)
#33
Message was sent while issue was closed.
On 2017/01/11 00:20:15, Timothy Loh wrote:
> A revert of this CL (patchset #11 id:200001) has been created in
> https://codereview.chromium.org/2623063002/ by mailto:timloh@chromium.org.
>
> The reason for reverting is: Added test is failing on WebKit Mac10.11 (retina)
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....
The links don't appear to work anymore, but here is the output from the test:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11_...
This is a testharness.js-based test.
PASS # AUDIT TASK RUNNER STARTED.
PASS > [basic test small] Start oscillator slightly past a sample frame
PASS Oscillator.start(1.25 frames) equals
[0,0,0.08628636579792338,0.20022300402084467,0.3115057926840881,0.41865973753742813,0.5202645699620939,0.6149735718768643,0.7015314257708557,0.7787908532703041,0.8457278217039733,0.9014551171122457,0.9452341037968682,0.9764845145447687,0.9947921417617265,0.999914327574007...]
with an element-wise tolerance of
{"absoluteThreshold":0.00010842,"relativeThreshold":0}.
FAIL X SNR (dB) is not greater than or equal to 84.055. Got 84.05493268231409.
assert_true: expected true got false
FAIL < [basic test small] 1 out of 2 assertions were failed. assert_true:
expected true got false
PASS > [basic test big] Start oscillator slightly before a sample frame
FAIL X Oscillator.start(1.75 frames) does not equal
[0,0,0.02879395236826347,0.14349262199117932,0.25628937313299666,0.3656891447750543,0.47024190105748226,0.5685618507342639,0.6593458151000688,0.7413905009317422,0.813608449500787,0.8750424502611525,0.9248782281665496,0.9624552364536474,0.9872754118385365,0.9990097760809875...]
with an element-wise tolerance of
{"absoluteThreshold":0.00010838,"relativeThreshold":0}.
Index Actual Expected AbsError RelError Test threshold
[23974] 5.5058568716049194e-2 5.4950179912477984e-2 1.0838880357121050e-4 1.9724922419516551e-3 1.0838000000000000e-4
Max AbsError of 1.0838880357121050e-4 at index of 23974.
Max RelError of 1.9724922419516551e-3 at index of 23974. assert_true: expected
true got false
PASS SNR (dB) is greater than or equal to 84.056.
FAIL < [basic test big] 1 out of 2 assertions were failed. assert_true: expected
true got false
PASS > [diff big offset] Test sampling with start offset greater than 1/2
sampling frame
PASS Delayed cosine oscillator at sample rate 24000 equals
[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0.9991217255592346,0.9876876473426819...] with an
element-wise tolerance of {"absoluteThreshold":4.1724e-7,"relativeThreshold":0}.
PASS SNR (dB) is greater than or equal to 137.536.
PASS < [diff big offset] All assertions passed. (total 2 assertions)
PASS > [diff small offset] Test sampling with start offset less than 1/2
sampling frame
PASS Delayed cosine oscillator at sample rate 48000 equals
[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0...] with an element-wise tolerance of
{"absoluteThreshold":4.1724e-7,"relativeThreshold":0}.
PASS SNR (dB) is greater than or equal to 137.536.
PASS < [diff small offset] All assertions passed. (total 2 assertions)
FAIL # AUDIT TASK RUNNER FINISHED: 2 out of 4 tasks were failed. assert_true:
expected true got false
Harness: the test ran to completion.
The thresholds are a little too tight for 10.11.
Raymond Toy
Description was changed from ========== Sub-sample accurate start of OscillatorNode Previously, an oscillator would start ...
3 years, 11 months ago
(2017-01-11 16:49:47 UTC)
#34
Message was sent while issue was closed.
Description was changed from
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=Oscillator/start-sampling.html
Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#442669}
Committed:
https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d...
==========
to
==========
Sub-sample accurate start of OscillatorNode
Previously, an oscillator would start at the nearest sample frame
boundary. This can produce noticeable effects.
Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.
BUG=631576
TEST=Oscillator/start-sampling.html
Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#442669}
Committed:
https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d...
==========
hongchan
lgtm
3 years, 11 months ago
(2017-01-11 19:51:39 UTC)
#35
lgtm
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
3 years, 11 months ago
(2017-01-11 21:05:09 UTC)
#36
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago
(2017-01-11 23:07:08 UTC)
#40
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.
Raymond Toy
On 2017/01/11 23:07:08, commit-bot: I haz the power wrote: > Prior attempt to commit was ...
3 years, 11 months ago
(2017-01-12 16:06:10 UTC)
#41
On 2017/01/11 23:07:08, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.
Manually verified (via git log) that this landed as commit
607f279225fce413a8f6f5247540494b969dd612
Cr-Commit-Position: refs/heads/master@{#443040}
Issue 2186813003: Sub-sample accurate start of OscillatorNode
(Closed)
Created 4 years, 4 months ago by Raymond Toy
Modified 3 years, 11 months ago
Reviewers: hongchan
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 8
Chromium Code Reviews
Issue
2186813003:
Sub-sample accurate start of OscillatorNode (Closed)
