Get rid of CaretBase::m_caretLocalRect

Get rid of CaretBase::m_caretLocalRect

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2623053006
Cr-Commit-Position: refs/heads/master@{#443207}
Committed: https://chromium.googlesource.com/chromium/src/+/05fd6942317394a4dbc4aae9fddc5511bb1fe00b

[yosin_UTC9, 2017-01-11 07:58:15]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 07:58:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 10:26:40]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-12 04:58:32]

Description was changed from

==========
2017-01-11T16:55:37

2017-01-11T16:55:01

BUG=
==========

to

==========
Get rid of CaretBase::m_caretLocalRect

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-12 04:58:32]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-01-12 04:58:40]

PTAL

[Xiaocheng, 2017-01-12 08:21:42]

Is my understanding correct?

FrameCaret doesn't actually need the stored value of
CaretBase::m_caretLocalRect, since FrameCaret assigns it a newly calculated
value every time using it.

So this patch simply moves the ownership of m_caretLocalRect from CaretBase to
DragCaretController, and let FrameCaret use its newly calculated value directly.

https://codereview.chromium.org/2623053006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretBase.h (right):

https://codereview.chromium.org/2623053006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretBase.h:62: // |VisiblePosition| to
// "FrameCaret.cpp" as static file local function.
nit: remove extra "//"

[Xiaocheng, 2017-01-12 09:19:28]

lgtm

[yoichio, 2017-01-12 09:22:22]

Cool! lgtm

https://codereview.chromium.org/2623053006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/CaretBase.cpp (right):

https://codereview.chromium.org/2623053006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/CaretBase.cpp:106: LayoutRect
caretLocalRect =
nit: const LayoutRect

[yosin_UTC9, 2017-01-12 10:04:37]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-01-12 10:04:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
yoichio@chromium.org, xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2623053006/#ps20001
(title: "2017-01-12T19:03:43")

[commit-bot: I haz the power, 2017-01-12 10:04:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 11:25:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484215477347680,
"parent_rev": "9438f509f344dd4ded216be3c38505c09f35922d", "commit_rev":
"05fd6942317394a4dbc4aae9fddc5511bb1fe00b"}

[commit-bot: I haz the power, 2017-01-12 11:26:20]

Description was changed from

==========
Get rid of CaretBase::m_caretLocalRect

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes
==========

to

==========
Get rid of CaretBase::m_caretLocalRect

This patch gets rid of |CaretBase::m_caretLocalRect| to reduce number of states
in |CaretBase| to simplify class hiarachity for improving code health.

After this patch, |CaretBase| represents |DisplayItemClient| for caret.
Following patch will rename |CaretBase| to |DisplayCaretItemClient| and
|DragCaretController|, which should rename to |DragCaret| is derived from
|DisplayCaretItemClient| and makes |DisplayCaretItemClient| had no public
member except for destructor.

This patch is a preparation of [1]

[1] http://crrev.com/1958093002 On-demand visible selection canonicalizataion

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2623053006
Cr-Commit-Position: refs/heads/master@{#443207}
Committed:
https://chromium.googlesource.com/chromium/src/+/05fd6942317394a4dbc4aae9fddc...
==========

[commit-bot: I haz the power, 2017-01-12 11:26:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05fd6942317394a4dbc4aae9fddc...