Get rid of CaretBase::m_caretLocalRect

third_party/WebKit/Source/core/editing/CaretBase.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 30 matching lines @@
 class LayoutBlock;
 
 class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase>,
                               public DisplayItemClient {
   WTF_MAKE_NONCOPYABLE(CaretBase);
 
  public:
   CaretBase();
   virtual ~CaretBase();
 
-  void invalidateCaretRect(Node*);
-  void clearCaretRect();
+  void invalidateCaretRect(Node*, const LayoutRect&);
   // Creating VisiblePosition causes synchronous layout so we should use the
   // PositionWithAffinity version if possible.
   // A position in HTMLTextFromControlElement is a typical example.
-  void updateCaretRect(const PositionWithAffinity& caretPosition);
-  void updateCaretRect(const VisiblePosition& caretPosition);
+  static LayoutRect computeCaretRect(const PositionWithAffinity& caretPosition);
+
+  // TODO(yosin): We should move |computeCaretRect()| with |VisiblePosition| to
+  // "FrameCaret.cpp" as static file local function.
+  static LayoutRect computeCaretRect(const VisiblePosition& caretPosition);
+
+  // TODO(yosin): We should move |absoluteBoundsForLocalRect()| with
+  // |VisiblePosition| to // "FrameCaret.cpp" as static file local function.

[Xiaocheng, 2017/01/12 08:21:42]

nit: remove extra "//"

   IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&) const;
+
+  // TODO(yosin): We should move |shouldRepaintCaret()| to "FrameCaret.cpp" as
+  // static file local function.
   bool shouldRepaintCaret(Node&) const;
-  void paintCaret(Node*,
-                  GraphicsContext&,
-                  const LayoutPoint&,
-                  DisplayItem::Type) const;
-
-  const LayoutRect& localCaretRectWithoutUpdate() const {
-    return m_caretLocalRect;
-  }
+  static void paintCaret(Node*,
+                         GraphicsContext&,
+                         const DisplayItemClient&,
+                         const LayoutRect& caretLocalRect,
+                         const LayoutPoint&,
+                         DisplayItem::Type);
 
   static LayoutBlock* caretLayoutObject(Node*);
   void invalidateLocalCaretRect(Node*, const LayoutRect&);
 
   // DisplayItemClient methods.
   LayoutRect visualRect() const override;
   String debugName() const final;
 
   DECLARE_VIRTUAL_TRACE();
 
  private:
-  // caret rect in coords local to the layoutObject responsible for painting the
-  // caret
-  LayoutRect m_caretLocalRect;
   LayoutRect m_visualRect;
 };
 
 }  // namespace blink
 
 #endif  // CaretBase_h