Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2622983002: Move "prePaint" under the "Update Layer Tree" devtools timeline step (Closed)

Created:
3 years, 11 months ago by pdr.
Modified:
3 years, 11 months ago
Reviewers:
caseq, chrishtr, xianzhanzhu
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move "prePaint" under the "Update Layer Tree" devtools timeline step Slimming paint invalidation (--enable-slimming-paint-invalidation) moves paint invalidation to a new "pre-paint" document lifecycle stage. This patch moves prePaint under the "Update Layer Tree" timeline category, and adds a comment to move this under "Paint" for slimming paint v2 (see discussion in https://codereview.chromium.org/2623613008). BUG=679403 Review-Url: https://codereview.chromium.org/2622983002 Cr-Commit-Position: refs/heads/master@{#442975} Committed: https://chromium.googlesource.com/chromium/src/+/5a213ac08a1ea69d04c2fc9e4f21fe53c109ff52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
pdr.
3 years, 11 months ago (2017-01-10 20:36:26 UTC) #2
chrishtr
lgtm
3 years, 11 months ago (2017-01-10 21:15:38 UTC) #3
caseq
lgtm
3 years, 11 months ago (2017-01-10 21:58:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622983002/1
3 years, 11 months ago (2017-01-10 22:02:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97331)
3 years, 11 months ago (2017-01-10 23:30:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622983002/1
3 years, 11 months ago (2017-01-10 23:36:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97447)
3 years, 11 months ago (2017-01-11 01:05:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622983002/1
3 years, 11 months ago (2017-01-11 05:30:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97817)
3 years, 11 months ago (2017-01-11 07:04:23 UTC) #16
pdr.
On 2017/01/11 at 07:04:23, commit-bot wrote: > Try jobs failed on following builders: > android_n5x_swarming_rel ...
3 years, 11 months ago (2017-01-11 18:41:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622983002/1
3 years, 11 months ago (2017-01-11 18:41:57 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 19:16:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a213ac08a1ea69d04c2fc9e4f21...

Powered by Google App Engine
This is Rietveld 408576698