Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2622983002: Move "prePaint" under the "Update Layer Tree" devtools timeline step (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2920 matching lines...) Expand 10 before | Expand all | Expand 10 after
2931 if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) 2931 if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
2932 invalidateTreeIfNeededRecursive(); 2932 invalidateTreeIfNeededRecursive();
2933 2933
2934 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2934 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2935 if (view.compositor()->inCompositingMode()) 2935 if (view.compositor()->inCompositingMode())
2936 scrollingCoordinator()->updateAfterCompositingChangeIfNeeded(); 2936 scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
2937 } 2937 }
2938 2938
2939 updateCompositedSelectionIfNeeded(); 2939 updateCompositedSelectionIfNeeded();
2940 } 2940 }
2941
2942 // TODO(pdr): prePaint should be under the "Paint" devtools timeline step
2943 // for slimming paint v2.
2944 if (targetState >= DocumentLifecycle::PrePaintClean)
2945 prePaint();
2941 } 2946 }
2942 2947
2943 if (targetState >= DocumentLifecycle::PrePaintClean)
2944 prePaint();
2945
2946 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 2948 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
2947 DocumentAnimations::updateAnimations(layoutView()->document()); 2949 DocumentAnimations::updateAnimations(layoutView()->document());
2948 2950
2949 if (targetState == DocumentLifecycle::PaintClean) { 2951 if (targetState == DocumentLifecycle::PaintClean) {
2950 if (!m_frame->document()->printing()) 2952 if (!m_frame->document()->printing())
2951 paintTree(); 2953 paintTree();
2952 2954
2953 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 2955 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
2954 pushPaintArtifactToCompositor(); 2956 pushPaintArtifactToCompositor();
2955 2957
(...skipping 1946 matching lines...) Expand 10 before | Expand all | Expand 10 after
4902 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount; 4904 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount;
4903 ++reason) { 4905 ++reason) {
4904 if (m_mainThreadScrollingReasonsCounter[reason] > 0) { 4906 if (m_mainThreadScrollingReasonsCounter[reason] > 0) {
4905 reasons |= 1 << reason; 4907 reasons |= 1 << reason;
4906 } 4908 }
4907 } 4909 }
4908 return reasons; 4910 return reasons;
4909 } 4911 }
4910 4912
4911 } // namespace blink 4913 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698