Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2622903003: [ObjC ARC] Converts ios/chrome/common/app_group:main_app to ARC. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/common/app_group:main_app to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2622903003 Cr-Commit-Position: refs/heads/master@{#444058} Committed: https://chromium.googlesource.com/chromium/src/+/935c2218b2aa0ee8628ac91f0741c0c08ed0ae8c

Patch Set 1 #

Patch Set 2 : Remove scoped_block #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M ios/chrome/common/app_group/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics_mainapp.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics_mainapp.mm View 1 4 chunks +10 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
stkhapugin
Remove scoped_block
3 years, 11 months ago (2017-01-10 14:08:10 UTC) #3
stkhapugin
PTAL
3 years, 11 months ago (2017-01-10 16:59:35 UTC) #8
stkhapugin
PTAL
3 years, 11 months ago (2017-01-10 16:59:35 UTC) #9
stkhapugin
kindly ping
3 years, 11 months ago (2017-01-12 14:24:48 UTC) #12
sdefresne
lgtm
3 years, 11 months ago (2017-01-17 14:36:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622903003/20001
3 years, 11 months ago (2017-01-17 14:36:58 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:39:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/935c2218b2aa0ee8628ac91f0741...

Powered by Google App Engine
This is Rietveld 408576698