[ObjC ARC] Converts ios/chrome/app/application_delegate:application_delegate_internal to ARC.

[ObjC ARC] Converts ios/chrome/app/application_delegate:application_delegate_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2621943002
Cr-Commit-Position: refs/heads/master@{#444721}
Committed: https://chromium.googlesource.com/chromium/src/+/76a6b9b24f09b5d684f5305c1d60e6b8a2b745d2

[stkhapugin, 2017-01-10 13:49:53]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 13:50:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 13:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 13:57:31]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[stkhapugin, 2017-01-10 14:11:21]

add dependency on ios/chrome/common/app_group:main_app

[stkhapugin, 2017-01-10 14:11:33]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 14:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 15:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 15:27:27]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-01-10 16:05:43]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2017-01-10 16:05:44]

PTAL

[stkhapugin, 2017-01-12 14:25:13]

kindly ping

[sdefresne, 2017-01-17 14:48:29]

Sorry for the poor grammar of my comments. I copy-n-pasted them and only noticed
the grammar error when replying ...

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/app_state.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/app_state.mm:42: 
Do you forgot to add ARC guards here?

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/background_activity.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/background_activity.mm:17: 
Do you forgot to add ARC guards here?

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/metrics_mediator.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/metrics_mediator.mm:32: 
Do you forgot to add ARC guards here?

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/url_opener.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/url_opener.mm:14: 
Do you forgot to add the ARC guards here?

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/user_activity_handler.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/user_activity_handler.mm:33: 
Do you forgot to add ARC guards here?

[stkhapugin, 2017-01-17 14:53:55]

No problem! Thanks for catching this, not sure why they were not added by the
script. PTAL

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/app_state.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/app_state.mm:42: 
On 2017/01/17 14:48:29, sdefresne wrote:
> Do you forgot to add ARC guards here?

Done.

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/background_activity.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/background_activity.mm:17: 
On 2017/01/17 14:48:29, sdefresne wrote:
> Do you forgot to add ARC guards here?

Done.

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/metrics_mediator.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/metrics_mediator.mm:32: 
On 2017/01/17 14:48:29, sdefresne wrote:
> Do you forgot to add ARC guards here?

Done.

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/url_opener.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/url_opener.mm:14: 
On 2017/01/17 14:48:29, sdefresne wrote:
> Do you forgot to add the ARC guards here?

Done.

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/user_activity_handler.mm (right):

https://codereview.chromium.org/2621943002/diff/20001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/user_activity_handler.mm:33: 
On 2017/01/17 14:48:29, sdefresne wrote:
> Do you forgot to add ARC guards here?

Done.

[sdefresne, 2017-01-17 15:22:43]

lgtm

https://codereview.chromium.org/2621943002/diff/40001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/metrics_mediator.mm (right):

https://codereview.chromium.org/2621943002/diff/40001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/metrics_mediator.mm:258:
base::Bind(&app_group::main_app::ProcessPendingLogs, callback));
ProcessPendingLogs now takes a app_group::ProceduralBlockWithData instead of a
ScopedBlock. Should you also change callback to be just a regular block and not
a ScopedBlock?

[stkhapugin, 2017-01-19 12:44:31]

https://codereview.chromium.org/2621943002/diff/40001/ios/chrome/app/applicat...
File ios/chrome/app/application_delegate/metrics_mediator.mm (right):

https://codereview.chromium.org/2621943002/diff/40001/ios/chrome/app/applicat...
ios/chrome/app/application_delegate/metrics_mediator.mm:258:
base::Bind(&app_group::main_app::ProcessPendingLogs, callback));
On 2017/01/17 15:22:43, sdefresne wrote:
> ProcessPendingLogs now takes a app_group::ProceduralBlockWithData instead of a
> ScopedBlock. Should you also change callback to be just a regular block and
not
> a ScopedBlock?

Done.

[stkhapugin, 2017-01-19 12:44:35]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-01-19 12:44:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2621943002/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2017-01-19 12:44:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 13:49:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484829875365240,
"parent_rev": "5466789f07c47118956eaca0a9baf4f35b02737b", "commit_rev":
"76a6b9b24f09b5d684f5305c1d60e6b8a2b745d2"}

[commit-bot: I haz the power, 2017-01-19 13:49:59]

Description was changed from

==========
[ObjC ARC] Converts
ios/chrome/app/application_delegate:application_delegate_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts
ios/chrome/app/application_delegate:application_delegate_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2621943002
Cr-Commit-Position: refs/heads/master@{#444721}
Committed:
https://chromium.googlesource.com/chromium/src/+/76a6b9b24f09b5d684f5305c1d60...
==========

[commit-bot: I haz the power, 2017-01-19 13:50:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/76a6b9b24f09b5d684f5305c1d60...