Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2622893005:
[Android DomKey] Swap mapping for TVInputComposite and TVInputComponent (Closed)
Description[Android DomKey] Swap mapping for TVInputComposite and TVInputComponent
https://crrev.com/2501083002/ introduce these mappings but mis-placed values,
this CL swaps these values back.
BUG=670587
Review-Url: https://codereview.chromium.org/2622893005
Cr-Commit-Position: refs/heads/master@{#442929}
Committed: https://chromium.googlesource.com/chromium/src/+/bacc700b3d89b58024d726567a4947f05fa24af5
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by chongz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Swap mapping for TVInputComposite and TVInputComponent BUG=670587 ========== to ========== [DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed valued, this CL swaps these values. BUG=670587 ==========
Description was changed from ========== [DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed valued, this CL swaps these values. BUG=670587 ========== to ========== [DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ==========
Description was changed from ========== [DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ========== to ========== [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ==========
Description was changed from ========== [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ========== to ========== [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ==========
chongz@chromium.org changed reviewers: + garykac@chromium.org
garykac@ PTAL, thanks!
lgtm https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... File ui/events/keycodes/keyboard_code_conversion_android.cc (right): https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... ui/events/keycodes/keyboard_code_conversion_android.cc:340: case AKEYCODE_TV_INPUT_COMPONENT_1: Could you fix these to be in alphabetical order?
Thanks for reviewing! https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... File ui/events/keycodes/keyboard_code_conversion_android.cc (right): https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... ui/events/keycodes/keyboard_code_conversion_android.cc:340: case AKEYCODE_TV_INPUT_COMPONENT_1: On 2017/01/10 21:33:25, garykac wrote: > Could you fix these to be in alphabetical order? It seems to me that this table is in AKEYCODE value order, e.g. ``` AKEYCODE_TV_INPUT_HDMI_4 = 246 AKEYCODE_TV_INPUT_COMPOSITE_1 = 247 AKEYCODE_TV_INPUT_COMPOSITE_2 = 248 AKEYCODE_TV_INPUT_COMPONENT_1 = 249 AKEYCODE_TV_INPUT_COMPONENT_2 = 250 AKEYCODE_TV_INPUT_VGA_1 = 251 AKEYCODE_TV_AUDIO_DESCRIPTION = 252 ``` Or do you want me to reorder the whole table?
On 2017/01/10 22:21:36, chongz wrote: > Thanks for reviewing! > > https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... > File ui/events/keycodes/keyboard_code_conversion_android.cc (right): > > https://codereview.chromium.org/2622893005/diff/1/ui/events/keycodes/keyboard... > ui/events/keycodes/keyboard_code_conversion_android.cc:340: case > AKEYCODE_TV_INPUT_COMPONENT_1: > On 2017/01/10 21:33:25, garykac wrote: > > Could you fix these to be in alphabetical order? > > It seems to me that this table is in AKEYCODE value order, e.g. oh, then leave it in the current order. It looked mostly alphabetical, so I assumed. > Or do you want me to reorder the whole table? Nope, it's fine the way it is. In any case, if we wanted to re-order the entire table, that should be done in a separate cl.
The CQ bit was checked by chongz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484148692016990, "parent_rev":
"954c9c1df7a0f467fe6e09a67d58e90e9bff7116", "commit_rev":
"bacc700b3d89b58024d726567a4947f05fa24af5"}
Message was sent while issue was closed.
Description was changed from ========== [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 ========== to ========== [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent https://crrev.com/2501083002/ introduce these mappings but mis-placed values, this CL swaps these values back. BUG=670587 Review-Url: https://codereview.chromium.org/2622893005 Cr-Commit-Position: refs/heads/master@{#442929} Committed: https://chromium.googlesource.com/chromium/src/+/bacc700b3d89b58024d726567a49... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bacc700b3d89b58024d726567a49... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
