Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: ui/events/keycodes/keyboard_code_conversion_android.cc

Issue 2622893005: [Android DomKey] Swap mapping for TVInputComposite and TVInputComponent (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/keyboard_code_conversion_android.cc
diff --git a/ui/events/keycodes/keyboard_code_conversion_android.cc b/ui/events/keycodes/keyboard_code_conversion_android.cc
index f20e0737e271dbb142066730f10924b196578eda..5baef1990a9870a5a0f5e675f3819dbf7508500e 100644
--- a/ui/events/keycodes/keyboard_code_conversion_android.cc
+++ b/ui/events/keycodes/keyboard_code_conversion_android.cc
@@ -334,13 +334,13 @@ DomKey GetDomKeyFromAndroidKeycode(int keycode) {
case AKEYCODE_TV_INPUT_HDMI_4:
return DomKey::TV_INPUT_HDMI4;
case AKEYCODE_TV_INPUT_COMPOSITE_1:
- return DomKey::TV_INPUT_COMPONENT1;
+ return DomKey::TV_INPUT_COMPOSITE1;
case AKEYCODE_TV_INPUT_COMPOSITE_2:
- return DomKey::TV_INPUT_COMPONENT2;
+ return DomKey::TV_INPUT_COMPOSITE2;
case AKEYCODE_TV_INPUT_COMPONENT_1:
garykac 2017/01/10 21:33:25 Could you fix these to be in alphabetical order?
chongz 2017/01/10 22:21:36 It seems to me that this table is in AKEYCODE valu
- return DomKey::TV_INPUT_COMPOSITE1;
+ return DomKey::TV_INPUT_COMPONENT1;
case AKEYCODE_TV_INPUT_COMPONENT_2:
- return DomKey::TV_INPUT_COMPOSITE2;
+ return DomKey::TV_INPUT_COMPONENT2;
case AKEYCODE_TV_INPUT_VGA_1:
return DomKey::TV_INPUT_VGA1;
case AKEYCODE_TV_AUDIO_DESCRIPTION:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698