Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2622783002: [crankshaft] Remove dead Variable hole-checking code (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove dead Variable hole-checking code This is a follow-up on 45c11887929c1f0fbc54849d2627cd8bb90bcc37, which removed hole checks from full-codegen. Variables requiring hole checks always go through Ignition. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2622783002 Cr-Commit-Position: refs/heads/master@{#42196} Committed: https://chromium.googlesource.com/v8/v8/+/2aaf217bd05677c9dc8cab7242f698836a830b0a

Patch Set 1 #

Patch Set 2 : One more bailout-reason #

Patch Set 3 : Update golden files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -501 lines) Patch
M src/bailout-reason.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 13 chunks +27 lines, -100 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 3 chunks +6 lines, -48 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 3 chunks +0 lines, -35 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 2 11 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
adamk
3 years, 11 months ago (2017-01-10 00:51:00 UTC) #1
Benedikt Meurer
LGTM modulo missing re-goldening :-)
3 years, 11 months ago (2017-01-10 05:05:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622783002/40001
3 years, 11 months ago (2017-01-10 18:50:00 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/2aaf217bd05677c9dc8cab7242f698836a830b0a
3 years, 11 months ago (2017-01-10 19:20:02 UTC) #14
Michael Achenbach
On 2017/01/10 19:20:02, commit-bot: I haz the power wrote: > Committed patchset #3 (id:40001) as ...
3 years, 11 months ago (2017-01-10 19:38:54 UTC) #15
adamk
3 years, 11 months ago (2017-01-10 19:56:13 UTC) #16
Message was sent while issue was closed.
On 2017/01/10 19:38:54, Michael Achenbach wrote:
> On 2017/01/10 19:20:02, commit-bot: I haz the power wrote:
> > Committed patchset #3 (id:40001) as
> >
>
https://chromium.googlesource.com/v8/v8/+/2aaf217bd05677c9dc8cab7242f698836a8...
> 
> Breaks mips cross compile:
> https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder
> 
> Not reverting as builder is not lkgr relevant, but please provide a fix.

Fixed in https://codereview.chromium.org/2621123002/

Any idea why the tryjobs didn't catch this?

Powered by Google App Engine
This is Rietveld 408576698