Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/crankshaft/ppc/lithium-codegen-ppc.cc

Issue 2622783002: [crankshaft] Remove dead Variable hole-checking code (Closed)
Patch Set: Update golden files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.cc ('k') | src/crankshaft/ppc/lithium-ppc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/ppc/lithium-codegen-ppc.cc
diff --git a/src/crankshaft/ppc/lithium-codegen-ppc.cc b/src/crankshaft/ppc/lithium-codegen-ppc.cc
index f546dc22d2546f55b454347332ae415c7c6e5ebd..2956fccc0acee2be456f055204f03ea7deaf4e5e 100644
--- a/src/crankshaft/ppc/lithium-codegen-ppc.cc
+++ b/src/crankshaft/ppc/lithium-codegen-ppc.cc
@@ -2658,26 +2658,6 @@ void LCodeGen::DoLoadContextSlot(LLoadContextSlot* instr) {
Register context = ToRegister(instr->context());
Register result = ToRegister(instr->result());
__ LoadP(result, ContextMemOperand(context, instr->slot_index()));
- if (instr->hydrogen()->RequiresHoleCheck()) {
- __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
- if (instr->hydrogen()->DeoptimizesOnHole()) {
- __ cmp(result, ip);
- DeoptimizeIf(eq, instr, DeoptimizeReason::kHole);
- } else {
- if (CpuFeatures::IsSupported(ISELECT)) {
- Register scratch = scratch0();
- __ mov(scratch, Operand(factory()->undefined_value()));
- __ cmp(result, ip);
- __ isel(eq, result, scratch, result);
- } else {
- Label skip;
- __ cmp(result, ip);
- __ bne(&skip);
- __ mov(result, Operand(factory()->undefined_value()));
- __ bind(&skip);
- }
- }
- }
}
@@ -2687,19 +2667,6 @@ void LCodeGen::DoStoreContextSlot(LStoreContextSlot* instr) {
Register scratch = scratch0();
MemOperand target = ContextMemOperand(context, instr->slot_index());
- Label skip_assignment;
-
- if (instr->hydrogen()->RequiresHoleCheck()) {
- __ LoadP(scratch, target);
- __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
- __ cmp(scratch, ip);
- if (instr->hydrogen()->DeoptimizesOnHole()) {
- DeoptimizeIf(eq, instr, DeoptimizeReason::kHole);
- } else {
- __ bne(&skip_assignment);
- }
- }
-
__ StoreP(value, target, r0);
if (instr->hydrogen()->NeedsWriteBarrier()) {
SmiCheck check_needed = instr->hydrogen()->value()->type().IsHeapObject()
@@ -2709,8 +2676,6 @@ void LCodeGen::DoStoreContextSlot(LStoreContextSlot* instr) {
GetLinkRegisterState(), kSaveFPRegs,
EMIT_REMEMBERED_SET, check_needed);
}
-
- __ bind(&skip_assignment);
}
« no previous file with comments | « src/crankshaft/mips64/lithium-mips64.cc ('k') | src/crankshaft/ppc/lithium-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698