Change the logging of NotBootstrappedError.

Change the logging of NotBootstrappedError.

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666
Review-Url: https://codereview.chromium.org/2622693003
Cr-Commit-Position: refs/heads/master@{#443013}
Committed: https://chromium.googlesource.com/chromium/src/+/87f7645fd8cf2ce0c2a6964a5b9674b875063319

[BigBossZhiling, 2017-01-10 00:58:35]

Description was changed from

==========
Change the logging of NotBootstrappedError.

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666
==========

to

==========
Change the logging of NotBootstrappedError.

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666
==========

[BigBossZhiling, 2017-01-10 00:58:36]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[BigBossZhiling, 2017-01-10 00:59:03]

The CQ bit was checked by hzl@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 00:59:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-01-10 01:02:42]

I'm worried that the scary part isn't the log message but the exception trace.
Maybe we could log that only when runniwht with log level DEBUG?

https://codereview.chromium.org/2622693003/diff/1/build/android/pylib/android...
File build/android/pylib/android/logdog_logcat_monitor.py (right):

https://codereview.chromium.org/2622693003/diff/1/build/android/pylib/android...
build/android/pylib/android/logdog_logcat_monitor.py:32: 'Unable to enable
logdog_logcat, %s.', str(e).split(': ')[1])
I'm not sure that we ought to be messing with the error text from the
NotBootstrappedError.

[jbudorick, 2017-01-10 01:02:45]

I'm worried that the scary part isn't the log message but the exception trace.
Maybe we could log that only when runniwht with log level DEBUG?

[commit-bot: I haz the power, 2017-01-10 03:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:03:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[jbudorick, 2017-01-11 01:54:03]

https://codereview.chromium.org/2622693003/diff/40001/build/android/pylib/and...
File build/android/pylib/android/logdog_logcat_monitor.py (right):

https://codereview.chromium.org/2622693003/diff/40001/build/android/pylib/and...
build/android/pylib/android/logdog_logcat_monitor.py:31:
logging.exception('Unable to enable logdog_logcat: NotBootstrapped.')
This call logs the exception trace. To log the exception only at debug level,
you'd do something like:

  if logging.getLogger().isEnabledFor(logging.DEBUG):
    logging.exception(...)

(you could also use getEffectiveLevel() == logging.DEBUG)

[BigBossZhiling, 2017-01-11 19:05:29]

https://codereview.chromium.org/2622693003/diff/40001/build/android/pylib/and...
File build/android/pylib/android/logdog_logcat_monitor.py (right):

https://codereview.chromium.org/2622693003/diff/40001/build/android/pylib/and...
build/android/pylib/android/logdog_logcat_monitor.py:31:
logging.exception('Unable to enable logdog_logcat: NotBootstrapped.')
On 2017/01/11 01:54:03, jbudorick wrote:
> This call logs the exception trace. To log the exception only at debug level,
> you'd do something like:
> 
>   if logging.getLogger().isEnabledFor(logging.DEBUG):
>     logging.exception(...)
> 
> (you could also use getEffectiveLevel() == logging.DEBUG)

Done.

[jbudorick, 2017-01-11 19:06:43]

lgtm

[BigBossZhiling, 2017-01-11 19:07:46]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-01-11 19:08:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:20:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484161666429960,
"parent_rev": "1b5567e091c5aafff29f019055685e962979301a", "commit_rev":
"87f7645fd8cf2ce0c2a6964a5b9674b875063319"}

[commit-bot: I haz the power, 2017-01-11 22:21:35]

Description was changed from

==========
Change the logging of NotBootstrappedError.

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666
==========

to

==========
Change the logging of NotBootstrappedError.

Previously we log even the stacktrace of NotBootstrappedError. It turned
out that it really pollutes log by spamming the log with
stacktraces.

In this cl, we changed the logging of error to just one line.

BUG=675666

Review-Url: https://codereview.chromium.org/2622693003
Cr-Commit-Position: refs/heads/master@{#443013}
Committed:
https://chromium.googlesource.com/chromium/src/+/87f7645fd8cf2ce0c2a6964a5b96...
==========

[commit-bot: I haz the power, 2017-01-11 22:21:39]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/87f7645fd8cf2ce0c2a6964a5b96...