Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/pylib/android/logdog_logcat_monitor.py

Issue 2622693003: Change the logging of NotBootstrappedError. (Closed)
Patch Set: fixes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/android/logdog_logcat_monitor.py
diff --git a/build/android/pylib/android/logdog_logcat_monitor.py b/build/android/pylib/android/logdog_logcat_monitor.py
index 42cb41234f15da7e8f34778ef61d99860e6baae2..2125e2e7780bcd64ffae019fd82f4e86c03c1629 100644
--- a/build/android/pylib/android/logdog_logcat_monitor.py
+++ b/build/android/pylib/android/logdog_logcat_monitor.py
@@ -28,8 +28,8 @@ class LogdogLogcatMonitor(logcat_monitor.LogcatMonitor):
self._stream_client = bootstrap.ButlerBootstrap.probe().stream_client()
self._logdog_stream = self._stream_client.open_text(self._stream_name)
except bootstrap.NotBootstrappedError as e:
- logging.exception(
- 'Error not bootstrapped. Failed to start logdog: %s', e)
+ if logging.getLogger().isEnabledFor(logging.DEBUG):
+ logging.exception('Unable to enable logdog_logcat: %s.', e)
except (KeyError, ValueError) as e:
logging.exception('Error when creating stream_client/stream: %s.', e)
except Exception as e: # pylint: disable=broad-except
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698