|
|
Created:
3 years, 11 months ago by rune Modified:
3 years, 11 months ago Reviewers:
drott, Kunihiko Sakamoto, sof CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTry to do less work clearing the font-cache in StyleEngine::didDetach.
Clearing the whole font-cache without considering css-connected fonts
could be cheaper. This is a speculative fix for issue 677415.
BUG=677415
Review-Url: https://codereview.chromium.org/2622673003
Cr-Commit-Position: refs/heads/master@{#443202}
Committed: https://chromium.googlesource.com/chromium/src/+/1bb2f1d3c48652f9591ce16daa20f7c91ce0f761
Patch Set 1 #
Created: 3 years, 11 months ago
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by rune@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + sigbjornf@opera.com
I can see the value of avoiding removeFontFace(). However, as CSSFontSelector can have multiple clients, I'm wary this will be clearing too abruptly or too much. Could you try to find someone more familiar with this code to review?
rune@opera.com changed reviewers: + drott@chromium.org, ksakamoto@chromium.org
ksakamoto@ or drott@: is this something you could review?
lgtm
Overlaps with https://codereview.chromium.org/2624893003/
The CQ bit was checked by rune@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1484212254214980, "parent_rev": "78dd11ea48a9967a31b7064cbdcea8eb61ca73dc", "commit_rev": "1bb2f1d3c48652f9591ce16daa20f7c91ce0f761"}
Message was sent while issue was closed.
Description was changed from ========== Try to do less work clearing the font-cache in StyleEngine::didDetach. Clearing the whole font-cache without considering css-connected fonts could be cheaper. This is a speculative fix for issue 677415. BUG=677415 ========== to ========== Try to do less work clearing the font-cache in StyleEngine::didDetach. Clearing the whole font-cache without considering css-connected fonts could be cheaper. This is a speculative fix for issue 677415. BUG=677415 Review-Url: https://codereview.chromium.org/2622673003 Cr-Commit-Position: refs/heads/master@{#443202} Committed: https://chromium.googlesource.com/chromium/src/+/1bb2f1d3c48652f9591ce16daa20... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1bb2f1d3c48652f9591ce16daa20... |