Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2622673003: Try to do less work clearing the font-cache in StyleEngine::didDetach. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to do less work clearing the font-cache in StyleEngine::didDetach. Clearing the whole font-cache without considering css-connected fonts could be cheaper. This is a speculative fix for issue 677415. BUG=677415 Review-Url: https://codereview.chromium.org/2622673003 Cr-Commit-Position: refs/heads/master@{#443202} Committed: https://chromium.googlesource.com/chromium/src/+/1bb2f1d3c48652f9591ce16daa20f7c91ce0f761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
rune
3 years, 11 months ago (2017-01-11 14:38:26 UTC) #6
sof
I can see the value of avoiding removeFontFace(). However, as CSSFontSelector can have multiple clients, ...
3 years, 11 months ago (2017-01-11 14:51:08 UTC) #7
rune
ksakamoto@ or drott@: is this something you could review?
3 years, 11 months ago (2017-01-11 16:02:37 UTC) #9
Kunihiko Sakamoto
lgtm
3 years, 11 months ago (2017-01-12 01:59:14 UTC) #10
sof
Overlaps with https://codereview.chromium.org/2624893003/
3 years, 11 months ago (2017-01-12 06:32:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622673003/1
3 years, 11 months ago (2017-01-12 09:11:09 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 10:49:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bb2f1d3c48652f9591ce16daa20...

Powered by Google App Engine
This is Rietveld 408576698