third_party/WebKit/Source/core/dom/StyleEngine.cpp - Issue 2622673003: Try to do less work clearing the font-cache in StyleEngine::didDetach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.cpp

Issue 2622673003: Try to do less work clearing the font-cache in StyleEngine::didDetach. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/StyleEngine.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.cpp b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

index b225c0941afb20b79e1157522a89e75d7fd1788c..a708c8a72be49402c2b1954bd4468e06f505b74a 100644

--- a/third_party/WebKit/Source/core/dom/StyleEngine.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

@@ -451,7 +451,9 @@ void StyleEngine::didDetach() {

m_activeTreeScopes.clear();

m_viewportResolver = nullptr;

m_mediaQueryEvaluator = nullptr;

- clearFontCache();

+ if (m_fontSelector)

+ m_fontSelector->fontFaceCache()->clearAll();

+ m_fontSelector = nullptr;

}

void StyleEngine::clearFontCache() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »