Remove redundant IsRenderFrameLive check from RFHM::Navigate.

Remove redundant IsRenderFrameLive check from RFHM::Navigate.

The path where we're switching RenderFrameHosts and the old one isn't
live should already be handled by a check in
RFHM::UpdateStateForNavigate, which also does an early
CommitPending().

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2622673002
Cr-Commit-Position: refs/heads/master@{#442455}
Committed: https://chromium.googlesource.com/chromium/src/+/f0fa0e779b1b123328d52540983dc783876b33a1

[alexmos, 2017-01-09 19:10:51]

Description was changed from

==========
Remove redundant IsRenderFrameLive check from RFHM::Navigate.

The path where we're switching RenderFrameHosts and the old one isn't
live should already be handled by a check in
RFHM::UpdateStateForNavigate, which also does an early
CommitPending().

BUG=487872
==========

to

==========
Remove redundant IsRenderFrameLive check from RFHM::Navigate.

The path where we're switching RenderFrameHosts and the old one isn't
live should already be handled by a check in
RFHM::UpdateStateForNavigate, which also does an early
CommitPending().

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[alexmos, 2017-01-09 19:10:53]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:11:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 20:31:09]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2017-01-10 00:18:29]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-01-10 00:18:30]

Sounds like you're probably right.  Can you confirm manually using these steps?

1) Visit http://csreis.github.io.
2) Kill the renderer.
3) Type tests.netsekure.org/slow.php?seconds=5 into omnibox and hit enter.

If we still don't see the sad tab while waiting for the commit, then this LGTM.

[alexmos, 2017-01-10 00:41:40]

On 2017/01/10 00:18:30, Charlie Reis wrote:
> Sounds like you're probably right.  Can you confirm manually using these
steps?
> 
> 1) Visit http://csreis.github.io.
> 2) Kill the renderer.
> 3) Type tests.netsekure.org/slow.php?seconds=5 into omnibox and hit enter.
> 
> If we still don't see the sad tab while waiting for the commit, then this
LGTM.

Yes, I confirmed that we don't see the sad tab while waiting for the commit with
these steps, so I'll go ahead and land this.  Thanks!

(Also, +site-isolation-reviews)

[alexmos, 2017-01-10 00:42:04]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:42:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 02:42:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484008924510890, "parent_rev":
"58de2fd49950cbad65f5d1429e111cd6ea28f795", "commit_rev":
"f0fa0e779b1b123328d52540983dc783876b33a1"}

[commit-bot: I haz the power, 2017-01-10 02:42:39]

Description was changed from

==========
Remove redundant IsRenderFrameLive check from RFHM::Navigate.

The path where we're switching RenderFrameHosts and the old one isn't
live should already be handled by a check in
RFHM::UpdateStateForNavigate, which also does an early
CommitPending().

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove redundant IsRenderFrameLive check from RFHM::Navigate.

The path where we're switching RenderFrameHosts and the old one isn't
live should already be handled by a check in
RFHM::UpdateStateForNavigate, which also does an early
CommitPending().

BUG=487872
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2622673002
Cr-Commit-Position: refs/heads/master@{#442455}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0fa0e779b1b123328d52540983d...
==========

[commit-bot: I haz the power, 2017-01-10 02:42:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0fa0e779b1b123328d52540983d...