Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2622673002: Remove redundant IsRenderFrameLive check from RFHM::Navigate. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_manager.cc
diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc
index 6c55b6225e957b368f6288a9b47062fa286de7a0..abc23579cabd91dcd471277b3e78c469d4686a4d 100644
--- a/content/browser/frame_host/render_frame_host_manager.cc
+++ b/content/browser/frame_host/render_frame_host_manager.cc
@@ -215,18 +215,6 @@ RenderFrameHostImpl* RenderFrameHostManager::Navigate(
if (!dest_render_frame_host)
return nullptr; // We weren't able to create a pending render frame host.
- // If the current render_frame_host_ isn't live, we should create it so
- // that we don't show a sad tab while the dest_render_frame_host fetches
- // its first page. (Bug 1145340)
- if (dest_render_frame_host != render_frame_host_.get() &&
- !render_frame_host_->IsRenderFrameLive()) {
- // Note: we don't call InitRenderView here because we are navigating away
- // soon anyway, and we don't have the NavigationEntry for this host.
- delegate_->CreateRenderViewForRenderManager(
- render_frame_host_->render_view_host(), MSG_ROUTING_NONE,
- MSG_ROUTING_NONE, frame_tree_node_->current_replication_state());
- }
-
// If the renderer isn't live, then try to create a new one to satisfy this
// navigation request.
if (!dest_render_frame_host->IsRenderFrameLive()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698