Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2622643004: Revert of [HBD] Intercept Flash navigations in popup windows. (Closed)

Created:
3 years, 11 months ago by dewittj
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of [HBD] Intercept Flash navigations in popup windows. (patchset #1 id:1 of https://codereview.chromium.org/2623593002/ ) Reason for revert: PageReloadWaiter not defined. Original issue's description: > [HBD] Intercept Flash navigations in popup windows. > > This CL turns up the Flash download interception aggression - by making > it apply to popup windows as well. > > This should be fairly harmless. > > BUG=676096 > > Review-Url: https://codereview.chromium.org/2590363003 > Cr-Commit-Position: refs/heads/master@{#440518} > (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) > > Review-Url: https://codereview.chromium.org/2623593002 . > Cr-Commit-Position: refs/branch-heads/2924@{#703} > Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} > Committed: https://chromium.googlesource.com/chromium/src/+/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed TBR=tommycli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676096, 679496 Review-Url: https://codereview.chromium.org/2622643004 Cr-Commit-Position: refs/branch-heads/2924@{#707} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/1bd7c525a6024db82d6c5f24277c84b09edeb341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
M chrome/browser/plugins/flash_download_interception.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/plugins/flash_permission_browsertest.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M chrome/test/data/permissions/flash.js View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
dewittj
Created Revert of [HBD] Intercept Flash navigations in popup windows.
3 years, 11 months ago (2017-01-09 22:25:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622643004/1
3 years, 11 months ago (2017-01-09 22:25:51 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 22:36:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bd7c525a6024db82d6c5f24277c...

Powered by Google App Engine
This is Rietveld 408576698