Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2623593002: [HBD] Intercept Flash navigations in popup windows. (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[HBD] Intercept Flash navigations in popup windows. This CL turns up the Flash download interception aggression - by making it apply to popup windows as well. This should be fairly harmless. BUG=676096 Review-Url: https://codereview.chromium.org/2590363003 Cr-Commit-Position: refs/heads/master@{#440518} (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) Review-Url: https://codereview.chromium.org/2623593002 . Cr-Commit-Position: refs/branch-heads/2924@{#703} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/85b4f6a7e6cb7792c9af14a82a8260f66f4355ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M chrome/browser/plugins/flash_download_interception.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/plugins/flash_permission_browsertest.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/test/data/permissions/flash.js View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
tommycli
Committed patchset #1 (id:1) manually as 85b4f6a7e6cb7792c9af14a82a8260f66f4355ed.
3 years, 11 months ago (2017-01-09 19:43:50 UTC) #2
dewittj
3 years, 11 months ago (2017-01-09 22:24:59 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2622643004/ by dewittj@chromium.org.

The reason for reverting is: PageReloadWaiter not defined..

Powered by Google App Engine
This is Rietveld 408576698