Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2622543002: build.py should only use target 'All' on xcode (Closed)

Created:
3 years, 11 months ago by Bill Hesse
Modified:
3 years, 11 months ago
Reviewers:
Leaf, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M tools/build.py View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bill Hesse
3 years, 11 months ago (2017-01-09 11:45:20 UTC) #1
Leaf
https://codereview.chromium.org/2622543002/diff/1/tools/build.py File tools/build.py (right): https://codereview.chromium.org/2622543002/diff/1/tools/build.py#newcode459 tools/build.py:459: target == 'All' Shouldn't this be single equals?
3 years, 11 months ago (2017-01-09 11:57:18 UTC) #2
Bill Hesse
https://codereview.chromium.org/2622543002/diff/1/tools/build.py File tools/build.py (right): https://codereview.chromium.org/2622543002/diff/1/tools/build.py#newcode459 tools/build.py:459: target == 'All' On 2017/01/09 11:57:18, Leaf wrote: > ...
3 years, 11 months ago (2017-01-09 12:14:57 UTC) #3
Bill Hesse
https://codereview.chromium.org/2622543002/diff/1/tools/build.py File tools/build.py (right): https://codereview.chromium.org/2622543002/diff/1/tools/build.py#newcode459 tools/build.py:459: target == 'All' On 2017/01/09 11:57:18, Leaf wrote: > ...
3 years, 11 months ago (2017-01-09 12:15:22 UTC) #4
Leaf
lgtm
3 years, 11 months ago (2017-01-09 12:16:52 UTC) #5
Bill Hesse
3 years, 11 months ago (2017-01-09 12:21:12 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4e6ac19b3cf2cd2d820336cdf326f99e00c5799f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698