build.py should only use target 'All' on xcode

tools/build.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 
 import optparse
 import os
 import re
@@ skipping 437 matching lines @@
   build_config = utils.GetBuildConf(mode, arch, target_os)
   if not options.gyp:
     args = BuildNinjaCommand(options, target, target_os, mode, arch)
   else:
     os.environ['DART_BUILD_MODE'] = mode
     if HOST_OS == 'macos':
       filter_xcodebuild_output = True
       project_file = 'dart.xcodeproj'
       if os.path.exists('dart-%s.gyp' % CurrentDirectoryBaseName()):
         project_file = 'dart-%s.xcodeproj' % CurrentDirectoryBaseName()
+      if target == 'all':
+        target == 'All'

[Leaf, 2017/01/09 11:57:18]

Shouldn't this be single equals? 

[Bill Hesse, 2017/01/09 12:14:57]

Yes.

[Bill Hesse, 2017/01/09 12:15:22]

Done.

       args = ['xcodebuild',
               '-project',
               project_file,
               '-target',
               target,
               '-configuration',
               build_config,
               'SYMROOT=%s' % os.path.abspath('xcodebuild')
               ]
     elif HOST_OS == 'win32':
@@ skipping 115 matching lines @@
 def Main():
   utils.ConfigureJava()
   # Parse the options.
   parser = BuildOptions()
   (options, args) = parser.parse_args()
   if not ProcessOptions(options, args):
     parser.print_help()
     return 1
   # Determine which targets to build. By default we build the "all" target.
   if len(args) == 0:
-    if HOST_OS == 'macos':
-      targets = ['All']
-    else:
-      targets = ['all']
+    targets = ['all']
   else:
     targets = args
 
   # Build all targets for each requested configuration.
   for target in targets:
     for target_os in options.os:
       for mode in options.mode:
         for arch in options.arch:
           cross_build = utils.IsCrossBuild(target_os, arch)
           if target in ['create_sdk'] and cross_build:
             if BuildCrossSdk(options, target_os, mode, arch) != 0:
               return 1
           else:
             if BuildOneConfig(options, target, target_os,
                               mode, arch, cross_build) != 0:
               return 1
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(Main())