Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2350)

Unified Diff: tools/build.py

Issue 2622543002: build.py should only use target 'All' on xcode (Closed)
Patch Set: Fix error Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
diff --git a/tools/build.py b/tools/build.py
index 448b47e4599d5965ffaccc11bb1375bd46655d91..2645ef564074b82af237554d49f8005c5adba6ab 100755
--- a/tools/build.py
+++ b/tools/build.py
@@ -455,6 +455,8 @@ def BuildOneConfig(options, target, target_os, mode, arch, override_tools):
project_file = 'dart.xcodeproj'
if os.path.exists('dart-%s.gyp' % CurrentDirectoryBaseName()):
project_file = 'dart-%s.xcodeproj' % CurrentDirectoryBaseName()
+ if target == 'all':
+ target = 'All'
args = ['xcodebuild',
'-project',
project_file,
@@ -590,10 +592,7 @@ def Main():
return 1
# Determine which targets to build. By default we build the "all" target.
if len(args) == 0:
- if HOST_OS == 'macos':
- targets = ['All']
- else:
- targets = ['all']
+ targets = ['all']
else:
targets = args
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698