Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2622473002: Replace HTMLAttributeMode with HTMLStandardMode (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace HTMLAttributeMode with HTMLStandardMode HTMLAttributeMode is no longer any different to HTMLStandardMode as we now correctly parse HTML lengths in a separate routine instead of using the CSS parser. This patch thus removes the enum and replaces its usage with HTMLStandardMode. BUG=668478 Review-Url: https://codereview.chromium.org/2622473002 Cr-Commit-Position: refs/heads/master@{#442402} Committed: https://chromium.googlesource.com/chromium/src/+/05e671c1e4c641e231b9c89c14b0273591a14c3a

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserMode.h View 1 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Timothy Loh
3 years, 11 months ago (2017-01-09 07:08:52 UTC) #7
fs
LGTM, thanks!
3 years, 11 months ago (2017-01-09 10:36:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622473002/20001
3 years, 11 months ago (2017-01-09 23:18:51 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:37:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05e671c1e4c641e231b9c89c14b0...

Powered by Google App Engine
This is Rietveld 408576698