third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp - Issue 2622473002: Replace HTMLAttributeMode with HTMLStandardMode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2622473002: Replace HTMLAttributeMode with HTMLStandardMode (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserMode.h ('k') | third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

index a537649d107d676895550b7b60416f49652fbe3f..b63c13b7bb48815d7cc272902c4e78affca69bf4 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

@@ -154,9 +154,7 @@ CSSPrimitiveValue* consumeNumber(CSSParserTokenRange& range,

inline bool shouldAcceptUnitlessLength(double value,

CSSParserMode cssParserMode,

UnitlessQuirk unitless) {

- // TODO(timloh): Presentational HTML attributes shouldn't use the CSS parser

- // for lengths

- return value == 0 || isUnitLessLengthParsingEnabledForMode(cssParserMode) ||

+ return value == 0 || cssParserMode == SVGAttributeMode ||

(cssParserMode == HTMLQuirksMode && unitless == UnitlessQuirk::Allow);

}